Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 854043002: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/options. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/options. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=thakis@chromium.org Committed: https://crrev.com/6da56b3fcd5e45cd72a28bc88a2c2c42ebbfc59b Cr-Commit-Position: refs/heads/master@{#311763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -97 lines) Patch
M chrome/browser/chromeos/options/cert_library.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.h View 4 chunks +18 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/options/network_property_ui_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/passphrase_textfield.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.h View 1 chunk +14 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.h View 1 chunk +16 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 6 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.h View 1 chunk +12 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
5 years, 11 months ago (2015-01-15 21:13:18 UTC) #1
Nico
lgtm!
5 years, 11 months ago (2015-01-15 21:17:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854043002/1
5 years, 11 months ago (2015-01-15 21:25:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 23:25:23 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 23:26:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6da56b3fcd5e45cd72a28bc88a2c2c42ebbfc59b
Cr-Commit-Position: refs/heads/master@{#311763}

Powered by Google App Engine
This is Rietveld 408576698