Cache ntdll exports in ELF

chrome_elf/ntdll_cache_unittest.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <windows.h>
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "chrome_elf/ntdll_cache.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+// Test fixtures -------------------------------------------------------------
+
+class NTDLLCacheTest : public testing::Test {
+ protected:
+  virtual void SetUp() OVERRIDE {
+    InitCache();
+  }
+
+};

[robertshield, 2013/12/06 22:08:50]

nit: feels like there should be a extra blank lines around the "Tests" line.
Also not sure if the line-length comments add much to a file this size, though I
do like this kind of file markup in general.

+// Tests ---------------------------------------------------------------------
+TEST_F(NTDLLCacheTest, NtDLLCacheSanityCheck) {
+  HMODULE ntdll_handle = ::GetModuleHandle(L"ntdll.dll");
+  // Grab a couple random entries from the cache and make sure they match the
+  // addresses exported by ntdll.
+  EXPECT_EQ(::GetProcAddress(ntdll_handle, "A_SHAFinal"),
+            g_ntdll_lookup["A_SHAFinal"]);
+  EXPECT_EQ(::GetProcAddress(ntdll_handle, "ZwTraceControl"),
+            g_ntdll_lookup["ZwTraceControl"]);
+}
+
+} // namespace

[robertshield, 2013/12/06 22:08:50]

nit: two spaces before //