Fix dispatch on MemberSets to always go dynamic if needed.

Fix dispatch on MemberSets to always go dynamic if needed.
And a bug where we'd put a dynamic toString and == on Object that conflicts with the one that is actually on Object.

Committed: https://code.google.com/p/dart/source/detail?r=1494

[Jennifer Messerly, 2011-11-12 01:32:20]

tbr

The good news is this helps with the REPL, it fixes some bugs in noSuchMethod,
and a few tests.

The bad news is this adds a bit more dynamic dispatch to frogsh. But the planned
type inference for "var" should make that a lot better!

[nweiz, 2011-11-14 21:28:15]

http://codereview.chromium.org/8540030/diff/1/frog/member.dart
File frog/member.dart (right):

http://codereview.chromium.org/8540030/diff/1/frog/member.dart#newcode1341
frog/member.dart:1341: MemberSet(Member member, [bool isVar=false]):
Does isVar also need to be set for the library-local method sets for private
methods?

[Jennifer Messerly, 2011-11-15 06:02:28]

On 2011/11/14 21:28:15, nweiz wrote:
> http://codereview.chromium.org/8540030/diff/1/frog/member.dart
> File frog/member.dart (right):
> 
> http://codereview.chromium.org/8540030/diff/1/frog/member.dart#newcode1341
> frog/member.dart:1341: MemberSet(Member member, [bool isVar=false]):
> Does isVar also need to be set for the library-local method sets for private
> methods?

Suspect so. Feel free to fix, otherwise I'll catch it in a follow up.

[jimhug, 2011-12-14 18:53:13]

lgtm

I had some minor comments - but the good news is I waited so long to do this
review that you've already fixed everything I may have suggested.