src/runtime.cc - Issue 8540006: Catch OOM when sparse array join results in too large array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 8540006: Catch OOM when sparse array join results in too large array. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 7b61c3e13fe4e6203080af0138269175b4b0a07b..4e6355c6ae1edbfd6d6d179de2a051ba53477ce4 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -6970,7 +6970,8 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_SparseJoinWithSeparator) {

// Find total length of join result.

int string_length = 0;

bool is_ascii = separator->IsAsciiRepresentation();

- int max_string_length = SeqAsciiString::kMaxLength;

+ int max_string_length = is_ascii ? SeqAsciiString::kMaxLength

+ : SeqTwoByteString::kMaxLength;

bool overflow = false;

CONVERT_NUMBER_CHECKED(int, elements_length,

Int32, elements_array->length());

« no previous file with comments | « no previous file | no next file » | no next file with comments »