Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: services/tracing/main.cc

Issue 853943005: Make tracing work on Android (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address reviewer comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/tracing/BUILD.gn ('k') | services/tracing/trace_data_sink.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/tracing/main.cc
diff --git a/services/tracing/main.cc b/services/tracing/main.cc
index 2c95ccdac4d35eec54242ca263da336b81057486..dc2dec56f0998c569ff4f791597db6e67e7f671a 100644
--- a/services/tracing/main.cc
+++ b/services/tracing/main.cc
@@ -44,11 +44,9 @@ class TracingApp : public mojo::ApplicationDelegate,
}
// tracing::TraceCoordinator implementation.
- void Start(const mojo::String& base_name,
+ void Start(mojo::ScopedDataPipeProducerHandle stream,
const mojo::String& categories) override {
- base::FilePath base_name_path =
- base::FilePath::FromUTF8Unsafe(base_name.To<std::string>());
- sink_.reset(new TraceDataSink(base_name_path));
+ sink_.reset(new TraceDataSink(stream.Pass()));
collector_bindings_.ForAllBindings([categories](
TraceController* controller) { controller->StartTracing(categories); });
}
« no previous file with comments | « services/tracing/BUILD.gn ('k') | services/tracing/trace_data_sink.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698