Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 853943005: Make tracing work on Android (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
jamesr, eseidel
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make tracing work on Android Previously, the trace coordinator would try to write a trace to the file system, but it is awkward to write to the file system on Android. Instead, we now stream the trace data to a data pipe. The Sky debugger consumes that data pipe and sends it to the host via the command HTTP server. R=eseidel@chromium.org, jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9b3cd6fbae7ebd7352d3f322d566ddfbbb08df29

Patch Set 1 #

Patch Set 2 : git cl format #

Patch Set 3 : nits #

Total comments: 4

Patch Set 4 : Address reviewer comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -37 lines) Patch
M services/tracing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/tracing/main.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M services/tracing/trace_data_sink.h View 1 chunk +4 lines, -3 lines 0 comments Download
M services/tracing/trace_data_sink.cc View 1 chunk +24 lines, -18 lines 0 comments Download
M services/tracing/tracing.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/tools/debugger/prompt/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M sky/tools/debugger/prompt/prompt.cc View 1 2 3 5 chunks +33 lines, -9 lines 0 comments Download
A sky/tools/debugger/prompt/trace_collector.h View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
A sky/tools/debugger/prompt/trace_collector.cc View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-15 23:16:35 UTC) #1
abarth-chromium
5 years, 11 months ago (2015-01-15 23:49:13 UTC) #3
jamesr
lgtm https://codereview.chromium.org/853943005/diff/40001/sky/tools/debugger/prompt/trace_collector.cc File sky/tools/debugger/prompt/trace_collector.cc (right): https://codereview.chromium.org/853943005/diff/40001/sky/tools/debugger/prompt/trace_collector.cc#newcode38 sky/tools/debugger/prompt/trace_collector.cc:38: if (callback_requested_) can't you just check if callback_ ...
5 years, 11 months ago (2015-01-15 23:56:58 UTC) #4
eseidel
lgtm https://codereview.chromium.org/853943005/diff/40001/sky/tools/debugger/prompt/prompt.cc File sky/tools/debugger/prompt/prompt.cc (right): https://codereview.chromium.org/853943005/diff/40001/sky/tools/debugger/prompt/prompt.cc#newcode110 sky/tools/debugger/prompt/prompt.cc:110: web_server_->SetSendBufferSize( You should expain why you're donig this ...
5 years, 11 months ago (2015-01-16 00:07:25 UTC) #5
abarth-chromium
https://codereview.chromium.org/853943005/diff/40001/sky/tools/debugger/prompt/prompt.cc File sky/tools/debugger/prompt/prompt.cc (right): https://codereview.chromium.org/853943005/diff/40001/sky/tools/debugger/prompt/prompt.cc#newcode110 sky/tools/debugger/prompt/prompt.cc:110: web_server_->SetSendBufferSize( On 2015/01/16 at 00:07:25, eseidel wrote: > You ...
5 years, 11 months ago (2015-01-16 00:31:53 UTC) #6
abarth-chromium
5 years, 11 months ago (2015-01-16 00:32:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
9b3cd6fbae7ebd7352d3f322d566ddfbbb08df29 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698