Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 853933002: VTTCue: Don't compare m_displayPosition against undefinedPosition (Closed)

Created:
5 years, 11 months ago by fs
Modified:
5 years, 11 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

VTTCue: Don't compare m_displayPosition against undefinedPosition VTTCue::m_displayPosition is a std::pair<float, float>, and not explicitly initialized. There's no reason to assume it'll take on the value undefinedPosition, and always setting the computed value should not hurt. BUG=448000 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188471

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/html/track/vtt/VTTCue.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 11 months ago (2015-01-15 12:41:46 UTC) #2
philipj_slow
lgtm
5 years, 11 months ago (2015-01-15 13:43:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853933002/1
5 years, 11 months ago (2015-01-15 13:44:49 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 15:04:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188471

Powered by Google App Engine
This is Rietveld 408576698