base/i18n/i18n_constants.cc - Issue 853903003: Cleanup dead code in base/ as found by Scythe.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/i18n/i18n_constants.cc

Issue 853903003: Cleanup dead code in base/ as found by Scythe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/i18n/i18n_constants.h"	5 #include "base/i18n/i18n_constants.h"

6	6

7 namespace base {	7 namespace base {

8	8

9 const char kCodepageLatin1[] = "ISO-8859-1";	9 const char kCodepageLatin1[] = "ISO-8859-1";

10 const char kCodepageUTF8[] = "UTF-8";	10 const char kCodepageUTF8[] = "UTF-8";

	11

	12 #if 0

11 const char kCodepageUTF16BE[] = "UTF-16BE";	13 const char kCodepageUTF16BE[] = "UTF-16BE";
	Nico 2015/01/20 22:45:33 likewise. we shouldn't have if 0 blocks checked in likewise. we shouldn't have if 0 blocks checked in. Lei Zhang 2015/01/20 22:51:46 How about I add a comment? // The other possible Show quoted text On 2015/01/20 22:45:33, Nico wrote: > likewise. we shouldn't have if 0 blocks checked in. How about I add a comment? // The other possible options are UTF-16BE and UTF-16LE, but they are unused in Chromium as of this writing. Nico 2015/01/20 22:54:06 sgtm Show quoted text On 2015/01/20 22:51:46, Lei Zhang wrote: > On 2015/01/20 22:45:33, Nico wrote: > > likewise. we shouldn't have if 0 blocks checked in. > > How about I add a comment? > > // The other possible options are UTF-16BE and UTF-16LE, but they are unused in > Chromium as of this writing. sgtm Lei Zhang 2015/01/20 23:03:56 Done. Show quoted text On 2015/01/20 22:54:06, Nico wrote: > On 2015/01/20 22:51:46, Lei Zhang wrote: > > On 2015/01/20 22:45:33, Nico wrote: > > > likewise. we shouldn't have if 0 blocks checked in. > > > > How about I add a comment? > > > > // The other possible options are UTF-16BE and UTF-16LE, but they are unused > in > > Chromium as of this writing. > > sgtm Done.
12 const char kCodepageUTF16LE[] = "UTF-16LE";	14 const char kCodepageUTF16LE[] = "UTF-16LE";

	15 #endif

13	16

14 } // namespace base	17 } // namespace base

15	18

OLD	NEW

« base/i18n/i18n_constants.h ('K') | « base/i18n/i18n_constants.h ('k') | base/message_loop/message_loop.h » ('j') | no next file with comments »