Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1482)

Unified Diff: content/browser/web_contents/web_contents_view_mac.mm

Issue 853883007: Add occlusion support to WebContentsImpl and RenderWidgetHostView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove mac comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_mac.mm
diff --git a/content/browser/web_contents/web_contents_view_mac.mm b/content/browser/web_contents/web_contents_view_mac.mm
index 0433b145eef79e61c0f6406580711a24efcb0006..42b259adc5754f27ef44b0a3b313315d8eac4436 100644
--- a/content/browser/web_contents/web_contents_view_mac.mm
+++ b/content/browser/web_contents/web_contents_view_mac.mm
@@ -606,12 +606,6 @@ void WebContentsViewMac::CloseTab() {
// Occlusion notification APIs are new in Mavericks.
bool supportsOcclusionAPIs = base::mac::IsOSMavericksOrLater();
- // Use of occlusion APIs is causing bugs:
- // http://crbug.com/430968: focus set incorrectly.
- // http://crbug.com/431272: flashes of incorrect content.
- // http://crbug.com/310374: white flashes (comment 22).
- supportsOcclusionAPIs = false;
-
if (supportsOcclusionAPIs) {
if (oldWindow) {
[notificationCenter
@@ -635,11 +629,9 @@ void WebContentsViewMac::CloseTab() {
WebContentsImpl* webContents = [self webContents];
if (window && webContents) {
if ([window occlusionState] & NSWindowOcclusionStateVisible) {
- if (!webContents->should_normally_be_visible())
- webContents->WasShown();
+ webContents->WasUnOccluded();
} else {
- if (webContents->should_normally_be_visible())
- webContents->WasHidden();
+ webContents->WasOccluded();
}
}
}
« no previous file with comments | « content/browser/web_contents/web_contents_impl_unittest.cc ('k') | content/public/browser/render_widget_host_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698