Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Side by Side Diff: sky/engine/core/dom/Microtask.cpp

Issue 853883005: Add a trace event for running microtasks (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "sky/engine/config.h" 31 #include "sky/engine/config.h"
32 #include "sky/engine/core/dom/Microtask.h" 32 #include "sky/engine/core/dom/Microtask.h"
33 33
34 #include "base/bind.h" 34 #include "base/bind.h"
35 #include "sky/engine/bindings/core/v8/V8PerIsolateData.h" 35 #include "sky/engine/bindings/core/v8/V8PerIsolateData.h"
36 #include "sky/engine/platform/TraceEvent.h"
36 #include "sky/engine/public/platform/WebThread.h" 37 #include "sky/engine/public/platform/WebThread.h"
37 #include "v8/include/v8.h" 38 #include "v8/include/v8.h"
38 39
39 namespace blink { 40 namespace blink {
40 41
41 namespace { 42 namespace {
42 43
43 class Task : public WebThread::Task { 44 class Task : public WebThread::Task {
44 public: 45 public:
45 explicit Task(const base::Closure& closure) 46 explicit Task(const base::Closure& closure)
(...skipping 12 matching lines...) Expand all
58 59
59 } 60 }
60 61
61 void Microtask::performCheckpoint() 62 void Microtask::performCheckpoint()
62 { 63 {
63 v8::Isolate* isolate = v8::Isolate::GetCurrent(); 64 v8::Isolate* isolate = v8::Isolate::GetCurrent();
64 V8PerIsolateData* isolateData = V8PerIsolateData::from(isolate); 65 V8PerIsolateData* isolateData = V8PerIsolateData::from(isolate);
65 ASSERT(isolateData); 66 ASSERT(isolateData);
66 if (isolateData->recursionLevel() || isolateData->performingMicrotaskCheckpo int()) 67 if (isolateData->recursionLevel() || isolateData->performingMicrotaskCheckpo int())
67 return; 68 return;
69 TRACE_EVENT0("v8", "v8.runMicrotasks");
68 isolateData->setPerformingMicrotaskCheckpoint(true); 70 isolateData->setPerformingMicrotaskCheckpoint(true);
69 isolate->RunMicrotasks(); 71 isolate->RunMicrotasks();
70 isolateData->setPerformingMicrotaskCheckpoint(false); 72 isolateData->setPerformingMicrotaskCheckpoint(false);
71 } 73 }
72 74
73 static void microtaskFunctionCallback(void* data) 75 static void microtaskFunctionCallback(void* data)
74 { 76 {
75 OwnPtr<WebThread::Task> task = adoptPtr(static_cast<WebThread::Task*>(data)) ; 77 OwnPtr<WebThread::Task> task = adoptPtr(static_cast<WebThread::Task*>(data)) ;
76 task->run(); 78 task->run();
77 } 79 }
78 80
79 void Microtask::enqueueMicrotask(PassOwnPtr<WebThread::Task> callback) 81 void Microtask::enqueueMicrotask(PassOwnPtr<WebThread::Task> callback)
80 { 82 {
81 v8::Isolate* isolate = v8::Isolate::GetCurrent(); 83 v8::Isolate* isolate = v8::Isolate::GetCurrent();
82 isolate->EnqueueMicrotask(&microtaskFunctionCallback, callback.leakPtr()); 84 isolate->EnqueueMicrotask(&microtaskFunctionCallback, callback.leakPtr());
83 } 85 }
84 86
85 void Microtask::enqueueMicrotask(const base::Closure& callback) 87 void Microtask::enqueueMicrotask(const base::Closure& callback)
86 { 88 {
87 enqueueMicrotask(adoptPtr(new Task(callback))); 89 enqueueMicrotask(adoptPtr(new Task(callback)));
88 } 90 }
89 91
90 } // namespace blink 92 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698