Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 853853002: win: Stub reorganization of MultiprocessExec (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Stub reorganization of MultiprocessExec This is moving towards having tests be in terms of MultiprocessExec rather than Multiprocess/MachMultiprocess. I had some difficulty in coming up with a way to do that directly, so this patch is just some stubbing to move in hopefully the right direction. In particular, makes multiprocess.h and multiprocess_exec.h #include-able on Windows, makes the existing .cc implementations of those POSIX-specific, and adds an (unimplemented) stub of multiprocess_exec for Windows. I think the subsequent steps are something like: - properly implement for Windows - make MachMultiprocess be implemented in terms of Exec (or possibly always have the "mach" bits available - move all tests to use Exec - merge Multiprocess and MultiprocessExec into one interface. R=mark@chromium.org BUG=crashpad:7

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : empty stub on windows #

Patch Set 4 : mac #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -713 lines) Patch
M compat/win/sys/types.h View 1 chunk +2 lines, -0 lines 0 comments Download
M snapshot/mac/mach_o_image_annotations_reader_test.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M snapshot/mac/process_reader_test.cc View 1 2 3 9 chunks +9 lines, -9 lines 0 comments Download
M util/mach/exception_ports_test.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M util/mach/mach_message_server_test.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M util/net/http_transport_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M util/test/mac/mach_multiprocess.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M util/test/multiprocess.h View 2 chunks +12 lines, -11 lines 0 comments Download
D util/test/multiprocess.cc View 1 chunk +0 lines, -218 lines 0 comments Download
D util/test/multiprocess_exec.cc View 1 chunk +0 lines, -140 lines 0 comments Download
A + util/test/multiprocess_exec_posix.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D util/test/multiprocess_exec_test.cc View 1 2 3 4 3 chunks +11 lines, -4 lines 0 comments Download
A util/test/multiprocess_exec_win.cc View 1 2 3 4 1 chunk +71 lines, -0 lines 0 comments Download
A + util/test/multiprocess_posix.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + util/test/multiprocess_posix_test.cc View 1 2 3 8 chunks +15 lines, -15 lines 0 comments Download
D util/test/multiprocess_test.cc View 1 chunk +0 lines, -289 lines 0 comments Download
M util/util.gyp View 1 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scottmg
5 years, 11 months ago (2015-01-16 03:54:33 UTC) #2
scottmg
Closing in favour of https://codereview.chromium.org/853853002/ which includes the beginning of the Windows implementation.
5 years, 11 months ago (2015-01-27 01:32:17 UTC) #3
scottmg
5 years, 11 months ago (2015-01-27 01:32:36 UTC) #4
Message was sent while issue was closed.
On 2015/01/27 01:32:17, scottmg wrote:
> Closing in favour of https://codereview.chromium.org/853853002/ which includes
> the beginning of the Windows implementation.

Er, in favour of https://codereview.chromium.org/880763002/ rather.

Powered by Google App Engine
This is Rietveld 408576698