chrome/browser/history/in_memory_url_index.cc - Issue 853743002: First pass at fixing guest browser cookies issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/in_memory_url_index.cc

Issue 853743002: First pass at fixing guest browser cookies issue. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Delete the Profile Manager. Guest Profile doesn't write to autocomplete/history. Views still needs … Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/in_memory_url_index.cc

diff --git a/chrome/browser/history/in_memory_url_index.cc b/chrome/browser/history/in_memory_url_index.cc

index 32fb87c7f92785830f34bd19b6b750c3c2844f26..172b9e0ddd0b346fe42baf0d8a8808e3f8159570 100644

--- a/chrome/browser/history/in_memory_url_index.cc

+++ b/chrome/browser/history/in_memory_url_index.cc

@@ -122,7 +122,13 @@ void InMemoryURLIndex::ShutDown() {

if (!GetCacheFilePath(&path))

return;

private_data_tracker_.TryCancelAll();

- URLIndexPrivateData::WritePrivateDataToCacheFileTask(private_data_, path);

+ // During browser TearDown this method was called from a thread that can

+ // perform FILE ops. Guest Profiles are closed on UI thread, so post a task.

+ if (content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE))

+ URLIndexPrivateData::WritePrivateDataToCacheFileTask(private_data_, path);

+ else

+ PostSaveToCacheFileTask();

needs_to_be_cached_ = false;

}