Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 853713002: Make map check in NamedStoreHandlerCompiler::GenerateFieldTypeChecks weak. (Closed)

Created:
5 years, 11 months ago by ulan
Modified:
5 years, 11 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make map check in NamedStoreHandlerCompiler::GenerateFieldTypeChecks weak. BUG=v8:3629 LOG=N Committed: https://crrev.com/a956bf582722dbc0b62f235f59a7ff4fc7615277 Cr-Commit-Position: refs/heads/master@{#26070}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix mips #

Patch Set 4 : Fix mips64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -19 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 2 1 chunk +9 lines, -6 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 2 3 1 chunk +9 lines, -6 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
5 years, 11 months ago (2015-01-14 16:25:36 UTC) #2
Igor Sheludko
lgtm
5 years, 11 months ago (2015-01-15 09:12:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853713002/60001
5 years, 11 months ago (2015-01-15 09:19:16 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-15 09:43:31 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 09:43:44 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a956bf582722dbc0b62f235f59a7ff4fc7615277
Cr-Commit-Position: refs/heads/master@{#26070}

Powered by Google App Engine
This is Rietveld 408576698