Implement automatic loading of dart:core_native_fields library

bin/gen_snapshot.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Generate a snapshot file after loading all the scripts specified on the
 // command line.
 
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
@@ skipping 75 matching lines @@
   for (intptr_t i = 0; i < size; i++) {
     file->WriteByte(buffer[i]);
   }
   delete file;
 }
 
 
 static void* SnapshotCreateCallback(void* data) {
   const char* script_name = reinterpret_cast<const char*>(data);
   Dart_Handle result;
+  Dart_Handle library;
   Dart_EnterScope();
 
   ASSERT(snapshot_filename != NULL);
 
-  // If a file is specified on the command line, load it up before a snapshot
-  // is created.
+  // Load up the script before a snapshot is created.
   if (script_name != NULL) {
     // Load the specified script.
-    Dart_Handle library = LoadSnapshotCreationScript(script_name);
-    if (Dart_IsError(library)) {
-      const char* err_msg = Dart_GetError(library);
-      fprintf(stderr, "Errors encountered while loading script: %s\n", err_msg);
-      Dart_ExitScope();
-      exit(255);
-    }
-
-    if (!Dart_IsLibrary(library)) {
-      fprintf(stderr,
-              "Expected a library when loading script: %s",
-              script_name);
-      Dart_ExitScope();
-      exit(255);
-    }
+    library = LoadSnapshotCreationScript(script_name);
   } else {
-    // Implicitly load builtin library.
-    Builtin_LoadLibrary();
-    // Setup the native resolver for built in library functions.
-    Builtin_SetNativeResolver();
+    // This is a generic dart snapshot which needs builtin library setup.
+    library = Builtin_LoadLibrary();
   }
-
+  if (Dart_IsError(library)) {
+    const char* err_msg = Dart_GetError(library);
+    fprintf(stderr, "Errors encountered while loading script: %s\n", err_msg);
+    Dart_ExitScope();
+    exit(255);
+  }
+  ASSERT(Dart_IsLibrary(library));
   uint8_t* buffer = NULL;
   intptr_t size = 0;
   // First create the snapshot.
   result = Dart_CreateSnapshot(&buffer, &size);
   if (Dart_IsError(result)) {
     const char* err_msg = Dart_GetError(result);
     fprintf(stderr, "Error while creating snapshot: %s\n", err_msg);
     Dart_ExitScope();
     exit(255);
   }
@@ skipping 39 matching lines @@
   // and writes out a snapshot.
   Dart_Isolate isolate = Dart_CreateIsolate(NULL, script_name);
   if (isolate == NULL) {
     return 255;
   }
 
   // Shutdown the isolate.
   Dart_ShutdownIsolate();
   return 0;
 }