Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 853693003: Remove the use of page id from determining whether to send the initial document notification. (Closed)

Created:
5 years, 11 months ago by Avi (use Gerrit)
Modified:
5 years, 11 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the use of page id from determining whether to send the initial document notification. BUG=369661 TEST=tests stay green Committed: https://crrev.com/4442a6507d04b27eea65065c3a849f3c9d570352 Reverted: https://crrev.com/a4758bcdbf0cf027f18e3e87f15de51ce757eee0 Committed: https://crrev.com/6301e78b5fd999d970ae3e2fbd0aa72aa503d59a Cr-Commit-Position: refs/heads/master@{#313111}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/renderer/render_frame_impl.cc View 1 2 3 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Charlie Reis
lgtm
5 years, 11 months ago (2015-01-23 07:26:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853693003/40001
5 years, 11 months ago (2015-01-23 07:26:57 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-23 07:45:12 UTC) #5
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4442a6507d04b27eea65065c3a849f3c9d570352 Cr-Commit-Position: refs/heads/master@{#312793}
5 years, 11 months ago (2015-01-23 07:46:12 UTC) #6
kochi
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/865423002/ by kochi@chromium.org. ...
5 years, 11 months ago (2015-01-23 09:25:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853693003/60001
5 years, 11 months ago (2015-01-26 20:10:25 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-26 20:17:35 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 20:18:50 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6301e78b5fd999d970ae3e2fbd0aa72aa503d59a
Cr-Commit-Position: refs/heads/master@{#313111}

Powered by Google App Engine
This is Rietveld 408576698