Issue 853683009: Revert of [turbofan] Make Factory::NewNumber() always return the minus_zero_value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 853683009: Revert of [turbofan] Make Factory::NewNumber() always return the minus_zero_value. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer

Modified:
5 years, 11 months ago

Reviewers:
dcarney, Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of [turbofan] Make Factory::NewNumber() always return the minus_zero_value. (patchset #1 id:1 of https://codereview.chromium.org/838263006/) Reason for revert: Breaks the tree Original issue's description: > [turbofan] Make Factory::NewNumber() always return the minus_zero_value. > > TEST=unittests > R=mstarzinger@chromium.org, dcarney@chromium.org > > Committed: https://crrev.com/55b3e268b2895e2c09230d39669a75b6ab4e7e4d > Cr-Commit-Position: refs/heads/master@{#26080} TBR=dcarney@chromium.org,mstarzinger@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a9d0d23405f9d9fca1bda238c27c3b5c4e52318c Cr-Commit-Position: refs/heads/master@{#26081}

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -23 lines)			Patch
M	src/factory.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	test/unittests/factory-unittest.cc	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	test/unittests/unittests.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

Created Revert of [turbofan] Make Factory::NewNumber() always return the minus_zero_value.

5 years, 11 months ago (2015-01-15 15:28:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853683009/1

5 years, 11 months ago (2015-01-15 15:29:26 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-15 15:29:49 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a9d0d23405f9d9fca1bda238c27c3b5c4e52318c
Cr-Commit-Position: refs/heads/master@{#26081}