|
Revert of Refactoring of Cast-related crypto code (patchset #19 id:350001 of https://codereview.chromium.org/792353002/)
Reason for revert:
fails to compile on Linux ChromiumOS GN https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/6146/steps/compile/logs/stdio
Original issue's description:
> Refactoring of Cast-related crypto code to use the same certificate validation logic in chrome.networkingPrivate API and Cast Channel authentication.
>
> Here's what's being done here:
> * Code from cast_auth_util_nss/openssl formed the basis a common Cast device validation component in /src/extensions/common/cast/cast_cert_validator*, and is now being extensively cleaned up in response to rsleevi's comments in this CL.
> * Both networking_private_crypto* and cast_auth_util* have been updated to use the new common code.
> * The current D-Bus-based implementation of VerifyDestination is going away per discussion with ChromeOS team, and is replaced with in-Chrome code in networking_private crypto*.
>
> BUG= 442650
>
> Committed: https://crrev.com/ed1e90f4f980709cef6a8a9c7e0f64cfe5578cdd
> Cr-Commit-Position: refs/heads/master@{#311460}
TBR=stevenjb@chromium.org,mef@chromium.org,rsleevi@chromium.org,vadimgo@chromium.org,mfoltz@chromium.org,kmarshall@chromium.org,rockot@chromium.org,brettw@chromium.org,sheretov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 442650
Committed: https://crrev.com/ee9d35aa735e6616855a0a497a055b41cd3079a6
Cr-Commit-Position: refs/heads/master@{#311461}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+736 lines, -797 lines) |
Patch |
 |
M |
chrome/browser/extensions/api/networking_private/crypto_verify_impl.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
|
View
|
|
3 chunks |
+0 lines, -43 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_chromeos.cc
|
View
|
|
1 chunk |
+0 lines, -43 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_chromeos.h
|
View
|
|
1 chunk |
+38 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_chromeos.cc
|
View
|
|
1 chunk |
+114 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc
|
View
|
|
2 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser_extensions.gypi
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_common.gypi
|
View
|
|
3 chunks |
+17 lines, -16 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_tests_unit.gypi
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/common/BUILD.gn
|
View
|
|
1 chunk |
+3 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/common/extensions/api/networking_private.json
|
View
|
|
1 chunk |
+2 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/common/extensions/api/networking_private/networking_private_crypto.h
|
View
|
|
2 chunks |
+10 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/common/extensions/api/networking_private/networking_private_crypto.cc
|
View
|
|
1 chunk |
+25 lines, -74 lines |
0 comments
|
Download
|
 |
M |
chrome/common/extensions/api/networking_private/networking_private_crypto_nss.cc
|
View
|
|
1 chunk |
+88 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/common/extensions/api/networking_private/networking_private_crypto_openssl.cc
|
View
|
|
2 chunks |
+103 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc
|
View
|
|
2 chunks |
+5 lines, -46 lines |
0 comments
|
Download
|
 |
M |
chrome/test/data/extensions/api_test/networking/test.js
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/test/data/extensions/api_test/networking_private/test.js
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
extensions/browser/BUILD.gn
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
extensions/browser/api/cast_channel/cast_auth_util.cc
|
View
|
|
4 chunks |
+0 lines, -57 lines |
0 comments
|
Download
|
 |
A |
extensions/browser/api/cast_channel/cast_auth_util_nss.cc
|
View
|
|
1 chunk |
+142 lines, -0 lines |
0 comments
|
Download
|
 |
A |
extensions/browser/api/cast_channel/cast_auth_util_openssl.cc
|
View
|
|
1 chunk |
+144 lines, -0 lines |
0 comments
|
Download
|
 |
M |
extensions/browser/api/cast_channel/cast_auth_util_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
extensions/common/BUILD.gn
|
View
|
|
3 chunks |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
D |
extensions/common/cast/cast_cert_validator.h
|
View
|
|
1 chunk |
+0 lines, -96 lines |
0 comments
|
Download
|
 |
D |
extensions/common/cast/cast_cert_validator.cc
|
View
|
|
1 chunk |
+0 lines, -30 lines |
0 comments
|
Download
|
 |
D |
extensions/common/cast/cast_cert_validator_nss.cc
|
View
|
|
1 chunk |
+0 lines, -155 lines |
0 comments
|
Download
|
 |
D |
extensions/common/cast/cast_cert_validator_openssl.cc
|
View
|
|
1 chunk |
+0 lines, -158 lines |
0 comments
|
Download
|
 |
M |
extensions/extensions.gyp
|
View
|
|
3 chunks |
+26 lines, -27 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|