Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 853653004: Gallery: Add items to GalleryDataModel before loading their metadata. (Closed)

Created:
5 years, 11 months ago by hirono
Modified:
5 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: Add items to GalleryDataModel before loading their metadata. Previously Gallery adds image items to its model after fetching the metadata. Because items are added by chunk, users cannot see all the items before load completes. It causes strange behavior e.g. users may move from the last item of the current chunk to the first item when the next chunk has not been loaded. The CL lets Gallery add all items to the model without fetching metadata. And then, lets Gallery dispatch 'content' event to update thumbnails after fetching metadata. BUG=chrome-os-partner:33931 TEST=manually Committed: https://crrev.com/0552d1680db5318d9e16708678a284037a19e4b8 Cr-Commit-Position: refs/heads/master@{#323898}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -157 lines) Patch
M ui/file_manager/file_manager/foreground/js/thumbnail_loader.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/css/gallery.css View 1 2 chunks +2 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 4 chunks +47 lines, -72 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_data_model.js View 2 chunks +21 lines, -17 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_data_model_unittest.js View 1 chunk +17 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/gallery_item.js View 3 chunks +20 lines, -6 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_util.js View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/mosaic_mode.js View 7 chunks +55 lines, -49 lines 0 comments Download
M ui/file_manager/gallery/js/ribbon.js View 1 2 chunks +10 lines, -6 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hirono
PTAL, thanks!
5 years, 8 months ago (2015-04-06 07:30:22 UTC) #5
yoshiki
lgtm with nit https://codereview.chromium.org/853653004/diff/40001/ui/file_manager/gallery/js/ribbon.js File ui/file_manager/gallery/js/ribbon.js (right): https://codereview.chromium.org/853653004/diff/40001/ui/file_manager/gallery/js/ribbon.js#newcode180 ui/file_manager/gallery/js/ribbon.js:180: element.style.marginLeft = '0'; nit: Should we ...
5 years, 8 months ago (2015-04-06 07:40:38 UTC) #6
hirono
Thanks! https://codereview.chromium.org/853653004/diff/40001/ui/file_manager/gallery/js/ribbon.js File ui/file_manager/gallery/js/ribbon.js (right): https://codereview.chromium.org/853653004/diff/40001/ui/file_manager/gallery/js/ribbon.js#newcode180 ui/file_manager/gallery/js/ribbon.js:180: element.style.marginLeft = '0'; On 2015/04/06 07:40:38, yoshiki wrote: ...
5 years, 8 months ago (2015-04-06 07:48:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853653004/60001
5 years, 8 months ago (2015-04-06 07:48:23 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 8 months ago (2015-04-06 08:17:08 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 08:18:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0552d1680db5318d9e16708678a284037a19e4b8
Cr-Commit-Position: refs/heads/master@{#323898}

Powered by Google App Engine
This is Rietveld 408576698