Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 853643002: App list: Changed launcher button's tooltip to "Launcher" in Ares mode. (Closed)

Created:
5 years, 11 months ago by Matt Giuca
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

App list: Changed launcher button's tooltip to "Launcher" in Ares mode. BUG=448644 Committed: https://crrev.com/224af1f65be9b9e8b11d485adc120e8d488a9fe3 Cr-Commit-Position: refs/heads/master@{#313836}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rearrange to call l10n_util only once. #

Patch Set 3 : Fixed SpokenFeedbackTest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M ash/ash_strings.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/shelf/app_list_button.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ash/shelf/app_list_shelf_item_delegate.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
Matt Giuca
See bug report (UI designers have confirmed).
5 years, 11 months ago (2015-01-14 22:45:12 UTC) #2
Matt Giuca
Ping.
5 years, 11 months ago (2015-01-19 00:56:53 UTC) #4
Matt Giuca
Adding Stefan as a reviewer. PTAL.
5 years, 11 months ago (2015-01-19 23:44:05 UTC) #6
Mr4D (OOO till 08-26)
Please see comment! https://codereview.chromium.org/853643002/diff/1/ash/shelf/app_list_shelf_item_delegate.cc File ash/shelf/app_list_shelf_item_delegate.cc (right): https://codereview.chromium.org/853643002/diff/1/ash/shelf/app_list_shelf_item_delegate.cc#newcode34 ash/shelf/app_list_shelf_item_delegate.cc:34: DCHECK(model); It might be better to ...
5 years, 11 months ago (2015-01-20 17:12:30 UTC) #7
Matt Giuca
PTAL. https://codereview.chromium.org/853643002/diff/1/ash/shelf/app_list_shelf_item_delegate.cc File ash/shelf/app_list_shelf_item_delegate.cc (right): https://codereview.chromium.org/853643002/diff/1/ash/shelf/app_list_shelf_item_delegate.cc#newcode34 ash/shelf/app_list_shelf_item_delegate.cc:34: DCHECK(model); On 2015/01/20 17:12:30, Mr4D wrote: > It ...
5 years, 11 months ago (2015-01-23 04:16:41 UTC) #8
Mr4D (OOO till 08-26)
lgtm
5 years, 11 months ago (2015-01-24 09:11:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853643002/20001
5 years, 11 months ago (2015-01-26 23:46:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/18475) Try jobs failed on following ...
5 years, 11 months ago (2015-01-27 00:55:12 UTC) #13
Matt Giuca
Didn't notice this failed the trybots. Need to update a test; dtseng PTAL.
5 years, 10 months ago (2015-01-29 23:17:06 UTC) #15
David Tseng
lgtm 
5 years, 10 months ago (2015-01-29 23:28:01 UTC) #16
Matt Giuca
Thanks for fast response!
5 years, 10 months ago (2015-01-29 23:33:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853643002/40001
5 years, 10 months ago (2015-01-29 23:34:07 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-30 00:30:49 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 00:31:55 UTC) #21
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/224af1f65be9b9e8b11d485adc120e8d488a9fe3
Cr-Commit-Position: refs/heads/master@{#313836}

Powered by Google App Engine
This is Rietveld 408576698