Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: frog/member.dart

Issue 8536056: better errors and error locations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/frogsh ('k') | frog/type.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/member.dart
diff --git a/frog/member.dart b/frog/member.dart
index f2481da856da483d5dbecefc5793b10d64831e46..c1a211ca852504097d0f8d433a36bd132d5730c0 100644
--- a/frog/member.dart
+++ b/frog/member.dart
@@ -78,6 +78,8 @@ interface Named {
bool get isNative();
String get jsname();
set jsname(String name);
+
+ SourceSpan get span();
}
class Member implements Named {
@@ -251,12 +253,12 @@ class TypeMember extends Member {
Value _set(MethodGenerator context, Node node, Value target, Value value,
[bool isDynamic=false]) {
- world.error('can not set type', node.span);
+ world.error('cannot set type', node.span);
}
Value invoke(MethodGenerator context, Node node, Value target, Arguments args,
[bool isDynamic=false]) {
- world.error('can not invoke type', node.span);
+ world.error('cannot invoke type', node.span);
}
}
@@ -755,9 +757,9 @@ class MethodMember extends Member {
void provideFieldSyntax() { _provideFieldSyntax = true; }
void providePropertySyntax() { _providePropertySyntax = true; }
- Value _set(MethodGenerator context, Node, Value target, Value value,
+ Value _set(MethodGenerator context, Node node, Value target, Value value,
[bool isDynamic=false]) {
- world.error('can not set method', definition.span);
+ world.error('cannot set method', node.span);
}
Value _get(MethodGenerator context, Node node, Value target,
« no previous file with comments | « frog/frogsh ('k') | frog/type.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698