Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 853603002: Merge html-office-public repo into src (Closed)

Created:
5 years, 11 months ago by raymes
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang, Sam McNally
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge html-office-public repo into src This was originally intended to be shared code with another project but that will no longer be the case. BUG=303491 Committed: https://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e Cr-Commit-Position: refs/heads/master@{#311400}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+555 lines, -58 lines) Patch
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +30 lines, -30 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_fit_page.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_fit_width.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_play.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_print.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_save.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_zoom_in.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_zoom_out.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_fit_page.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_fit_width.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_play.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_print.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_save.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_zoom_in.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_zoom_out.png View Binary file 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/viewer-button.css View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/viewer-button.html View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-button/viewer-button.js View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.css View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.html View 1 chunk +7 lines, -0 lines 0 comments Download
A + chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.js View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.css View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.html View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js View 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.css View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.js View 1 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-progress-bar/viewer-progress-bar.css View 1 chunk +71 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-progress-bar/viewer-progress-bar.html View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-progress-bar/viewer-progress-bar.js View 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-toolbar/viewer-toolbar.css View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-toolbar/viewer-toolbar.html View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/browser/resources/pdf/elements/viewer-toolbar/viewer-toolbar.js View 1 chunk +57 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/index.html View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/pdf/index-material.html View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
raymes
5 years, 11 months ago (2015-01-14 00:45:06 UTC) #2
Sam McNally
lgtm
5 years, 11 months ago (2015-01-14 00:52:06 UTC) #3
raymes
+thestig for (mechanical changes inside) chrome/browser/resources/component_extension_resources.grd
5 years, 11 months ago (2015-01-14 01:11:09 UTC) #5
Lei Zhang
rs lgtm
5 years, 11 months ago (2015-01-14 01:21:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853603002/20001
5 years, 11 months ago (2015-01-14 01:22:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/35800)
5 years, 11 months ago (2015-01-14 01:30:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853603002/40001
5 years, 11 months ago (2015-01-14 02:16:01 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-14 03:18:42 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 03:19:44 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e
Cr-Commit-Position: refs/heads/master@{#311400}

Powered by Google App Engine
This is Rietveld 408576698