Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: include/core/SkXfermode.h

Issue 853543003: Do some minor pre cleanup work before converting all xfermodes to XPs. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkXfermode.cpp » ('j') | src/effects/SkXfermodeImageFilter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkXfermode.h
diff --git a/include/core/SkXfermode.h b/include/core/SkXfermode.h
index 05fd81152a72e1c6c2898991fd918641260c3566..ea0c6c6f38a77b19eadc766a4c29bd159433c2d3 100644
--- a/include/core/SkXfermode.h
+++ b/include/core/SkXfermode.h
@@ -199,10 +199,7 @@ public:
fragment shader. If NULL, the effect should request access to destination color
(setWillReadDstColor()), and use that in the fragment shader (builder->dstColor()).
*/
- // TODO: Once all custom xp's have been created the background parameter will be required here.
- // We will always use the XPFactory if there is no background texture and the fragment if
- // there is one.
- virtual bool asFragmentProcessor(GrFragmentProcessor**, GrTexture* background = NULL) const;
+ virtual bool asFragmentProcessor(GrFragmentProcessor**, GrTexture* background) const;
/** A subclass may implement this factory function to work with the GPU backend. It is legal
to call this with xpf NULL to simply test the return value. If xpf is non-NULL then the
« no previous file with comments | « no previous file | src/core/SkXfermode.cpp » ('j') | src/effects/SkXfermodeImageFilter.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698