chrome/browser/history/expire_history_backend_unittest.cc - Issue 853533002: Use proper pair type in range-based for map iterations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/expire_history_backend_unittest.cc

Issue 853533002: Use proper pair type in range-based for map iterations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: supervised_user auto Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/history/expire_history_backend_unittest.cc

diff --git a/chrome/browser/history/expire_history_backend_unittest.cc b/chrome/browser/history/expire_history_backend_unittest.cc

index 2a3c8e09555c052243b49af8207ea04a027e810b..02fce40266d4affc01484e1086ccaf3b3721c423 100644

--- a/chrome/browser/history/expire_history_backend_unittest.cc

+++ b/chrome/browser/history/expire_history_backend_unittest.cc

@@ -333,7 +333,8 @@ void ExpireHistoryTest::EnsureURLInfoGone(const URLRow& row, bool expired) {

// EXPECT_FALSE(HasThumbnail(row.id()));

bool found_delete_notification = false;

- for (const std::pair<bool, URLRows>& pair : urls_deleted_notifications_) {

+ for (const URLsDeletedNotificationList::value_type& pair :

sdefresne 2015/01/14 10:47:08 nit: I slightly prefer const auto& here.

vmpstr 2015/01/14 17:32:16 Done.

+ urls_deleted_notifications_) {

EXPECT_EQ(expired, pair.first);

const history::URLRows& rows(pair.second);

history::URLRows::const_iterator it_row = std::find_if(

« no previous file with comments | « no previous file | chrome/browser/supervised_user/supervised_user_url_filter.cc » ('j') | no next file with comments »