components/autofill/core/browser/form_structure.cc - Issue 853523004: Autofill: Set requirements for number of recognized fields in an autofillable form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_structure.cc

Issue 853523004: Autofill: Set requirements for number of recognized fields in an autofillable form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More relaxed check for form tag Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/form_field.cc ('K') | « components/autofill/core/browser/form_structure.h ('k') | components/autofill/core/browser/form_structure_unittest.cc » ('j') | components/autofill/core/browser/name_field.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/form_structure.cc

diff --git a/components/autofill/core/browser/form_structure.cc b/components/autofill/core/browser/form_structure.cc

index b5cfd5e1f7787790e669210c29d4c965a8363e85..63adfcda4658a61d82c94c3b1163f47c2427bd48 100644

--- a/components/autofill/core/browser/form_structure.cc

+++ b/components/autofill/core/browser/form_structure.cc

@@ -353,7 +353,8 @@ FormStructure::FormStructure(const FormData& form)

active_field_count_(0),

upload_required_(USE_UPLOAD_RATES),

has_author_specified_types_(false),

- has_password_field_(false) {

+ has_password_field_(false),

+ is_unowned_(false) {

// Copy the form fields.

std::map<base::string16, size_t> unique_names;

for (std::vector<FormFieldData>::const_iterator field =

@@ -397,7 +398,7 @@ void FormStructure::DetermineHeuristicTypes() {

if (!has_author_specified_types_) {

ServerFieldTypeMap field_type_map;

- FormField::ParseFormFields(fields_.get(), &field_type_map);

+ FormField::ParseFormFields(fields_.get(), is_unowned_, &field_type_map);

for (size_t i = 0; i < field_count(); ++i) {

AutofillField* field = fields_[i];

ServerFieldTypeMap::iterator iter =