components/autofill/core/browser/autofill_manager.h - Issue 853523004: Autofill: Set requirements for number of recognized fields in an autofillable form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 853523004: Autofill: Set requirements for number of recognized fields in an autofillable form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More relaxed check for form tag Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/address_field.cc ('K') | « components/autofill/core/browser/address_field.cc ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | components/autofill/core/browser/credit_card_field.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.h

diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h

index ec9286c4ac8296614ee7a6c364fc60614cee0747..a7b252b50626ce2b12cd907bc9aaff81418571bb 100644

--- a/components/autofill/core/browser/autofill_manager.h

+++ b/components/autofill/core/browser/autofill_manager.h

@@ -140,6 +140,7 @@ class AutofillManager : public AutofillDownloadManager::Observer,

void SetTestDelegate(AutofillManagerTestDelegate* delegate);

void OnFormsSeen(const std::vector<FormData>& forms,

+ size_t unowned_form_index,

const base::TimeTicks& timestamp);

// Processes the submitted |form|, saving any new Autofill data and uploading

@@ -295,7 +296,8 @@ class AutofillManager : public AutofillDownloadManager::Observer,

const AutofillType& type) const;

// Parses the forms using heuristic matching and querying the Autofill server.

- void ParseForms(const std::vector<FormData>& forms);

+ void ParseForms(const std::vector<FormData>& forms,

+ size_t unowned_form_index);

// Imports the form data, submitted by the user, into |personal_data_|.

void ImportFormData(const FormStructure& submitted_form);