components/autofill/core/browser/form_structure.h - Issue 853523004: Autofill: Set requirements for number of recognized fields in an autofillable form

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_structure.h

Issue 853523004: Autofill: Set requirements for number of recognized fields in an autofillable form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, change variable name Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/form_field.cc ('K') | « components/autofill/core/browser/form_field_unittest.cc ('k') | components/autofill/core/browser/form_structure.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/form_structure.h

diff --git a/components/autofill/core/browser/form_structure.h b/components/autofill/core/browser/form_structure.h

index e93621012de98cda8af744caa37081fded771b8f..119117aa96df1342dbf1e3a1ec8c57b41d429c15 100644

--- a/components/autofill/core/browser/form_structure.h

+++ b/components/autofill/core/browser/form_structure.h

@@ -43,7 +43,7 @@ struct FormDataPredictions;

// in the fields along with additional information needed by Autofill.

class FormStructure {

public:

- FormStructure(const FormData& form);

+ explicit FormStructure(const FormData& form);

virtual ~FormStructure();

// Runs several heuristics against the form fields to determine their possible

@@ -254,6 +254,9 @@ class FormStructure {

// True if the form contains at least one password field.

bool has_password_field_;

+ // True if the form is a <form>.

+ bool is_form_tag_;

DISALLOW_COPY_AND_ASSIGN(FormStructure);

};