Autofill: Set requirements for number of recognized fields in an autofillable form

components/autofill/core/browser/name_field.cc

Index: components/autofill/core/browser/name_field.cc
diff --git a/components/autofill/core/browser/name_field.cc b/components/autofill/core/browser/name_field.cc
index 8532de13c3a1b1f7bd25d04c3a3b90fdd7856a2a..b0e87f7c8e8c72b97a542c150d1ff8705fb6c921 100644
--- a/components/autofill/core/browser/name_field.cc
+++ b/components/autofill/core/browser/name_field.cc
@@ -73,6 +73,7 @@ scoped_ptr<FormField> NameField::Parse(AutofillScanner* scanner) {
 
 // This is overriden in concrete subclasses.
 bool NameField::ClassifyField(ServerFieldTypeMap* map) const {

[Evan Stade, 2015/01/22 23:43:44]

why is this function even implemented if this is an abstract class?

[Lei Zhang, 2015/01/22 23:58:12]

I have no idea. I can take a look later. Reverting for now.

+  NOTREACHED();
   return false;
 }
 
@@ -100,6 +101,7 @@ bool FullNameField::ClassifyField(ServerFieldTypeMap* map) const {
 }
 
 FullNameField::FullNameField(AutofillField* field) : field_(field) {
+  DCHECK(field);

[Evan Stade, 2015/01/22 23:43:44]

ditto

[Lei Zhang, 2015/01/22 23:58:12]

Reverted.

 }
 
 scoped_ptr<FirstLastNameField> FirstLastNameField::ParseSpecificName(