Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: components/autofill/core/browser/form_field.h

Issue 853523004: Autofill: Set requirements for number of recognized fields in an autofillable form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_field.h
diff --git a/components/autofill/core/browser/form_field.h b/components/autofill/core/browser/form_field.h
index 43714ad60a70c682c237d0bd2ed81d2465a51f78..6a7701afe1941dbfb0bf2e2e2ae533319259c129 100644
--- a/components/autofill/core/browser/form_field.h
+++ b/components/autofill/core/browser/form_field.h
@@ -29,6 +29,7 @@ class FormField {
// The association is stored into |map|. Each field has a derived unique name
// that is used as the key into the |map|.
static void ParseFormFields(const std::vector<AutofillField*>& fields,
+ bool is_in_form_tag,
ServerFieldTypeMap* map);
protected:
@@ -115,9 +116,10 @@ class FormField {
// |fields| is both an input and an output parameter. Upon exit |fields|
// holds any remaining unclassified fields for further processing.
// Classification results of the processed fields are stored in |map|.
- static void ParseFormFieldsPass(ParseFunction parse,
- std::vector<AutofillField*>* fields,
- ServerFieldTypeMap* map);
+ // Returns the number of recognized fields.
+ static size_t ParseFormFieldsPass(ParseFunction parse,
+ std::vector<AutofillField*>* fields,
+ ServerFieldTypeMap* map);
// Returns true iff |type| matches |match_type|.
static bool MatchesFormControlType(const std::string& type, int match_type);

Powered by Google App Engine
This is Rietveld 408576698