Autofill: Set requirements for number of recognized fields in an autofillable form

components/autofill/core/browser/phone_field.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/phone_field.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
@@ skipping 222 matching lines @@
     }
   } else {
     ok = AddClassification(parsed_phone_fields_[FIELD_PHONE],
                            PHONE_HOME_WHOLE_NUMBER,
                            map);
   }
 
   return ok;
 }
 
+size_t PhoneField::FieldCount() const {

[Evan Stade, 2015/01/21 22:52:50]

why not just return 1? Why should three separate inputs [   ] [   ] [    ] count
differently from one big one [          ]?

[Lei Zhang, 2015/01/22 08:07:37]

Recognizing many fields in a phone number is a stronger signal than just one
field that's a PHONE_HOME_WHOLE_NUMBER, which could be the type of badly
classified fields we are trying to address in this CL.

+  size_t count = 0;
+  for (size_t i = 0; i < FIELD_MAX; ++i) {
+    if (parsed_phone_fields_[i])
+      ++count;
+  }
+
+  return count;
+}
+
 PhoneField::PhoneField() {
   memset(parsed_phone_fields_, 0, sizeof(parsed_phone_fields_));
 }
 
 // static
 base::string16 PhoneField::GetRegExp(RegexType regex_id) {
   switch (regex_id) {
     case REGEX_COUNTRY:
       return base::UTF8ToUTF16(kCountryCodeRe);
     case REGEX_AREA:
@@ skipping 13 matching lines @@
     case REGEX_EXTENSION:
       return base::UTF8ToUTF16(kPhoneExtensionRe);
     default:
       NOTREACHED();
       break;
   }
   return base::string16();
 }
 
 }  // namespace autofill