Autofill: Set requirements for number of recognized fields in an autofillable form

components/autofill/core/browser/form_field.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_FIELD_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_FIELD_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 11 matching lines @@
 // interface can identify themselves as a particular type of form field, e.g.
 // name, phone number, or address field.
 class FormField {
  public:
   virtual ~FormField() {}
 
   // Classifies each field in |fields| with its heuristically detected type.
   // The association is stored into |map|.  Each field has a derived unique name
   // that is used as the key into the |map|.
   static void ParseFormFields(const std::vector<AutofillField*>& fields,
+                              bool is_unowned_form,

[Evan Stade, 2015/01/21 22:52:50]

nit: |unowned_form| is a slight misnomer. How about |is_in_a_form|?

[Lei Zhang, 2015/01/22 08:07:37]

is_in_form_tag

                               ServerFieldTypeMap* map);
 
  protected:
   // A bit-field used for matching specific parts of a field in question.
   enum MatchType {
     // Attributes.
     MATCH_LABEL      = 1 << 0,
     MATCH_NAME       = 1 << 1,
     MATCH_VALUE      = 1 << 2,
 
@@ skipping 39 matching lines @@
   static bool AddClassification(const AutofillField* field,
                                 ServerFieldType type,
                                 ServerFieldTypeMap* map);
 
   // Derived classes must implement this interface to supply field type
   // information.  |ParseFormFields| coordinates the parsing and extraction
   // of types from an input vector of |AutofillField| objects and delegates
   // the type extraction via this method.
   virtual bool ClassifyField(ServerFieldTypeMap* map) const = 0;
 
+  // Returns the number of recognized fields.
+  virtual size_t FieldCount() const = 0;
+
  private:
   FRIEND_TEST_ALL_PREFIXES(FormFieldTest, Match);
 
   // Function pointer type for the parsing function that should be passed to the
   // ParseFormFieldsPass() helper function.
   typedef scoped_ptr<FormField> ParseFunction(AutofillScanner* scanner);
 
   // Matches |pattern| to the contents of the field at the head of the
   // |scanner|.
   // Returns |true| if a match is found according to |match_type|, and |false|
   // otherwise.
   static bool MatchAndAdvance(AutofillScanner* scanner,
                               const base::string16& pattern,
                               int match_type,
                               AutofillField** match);
 
   // Matches the regular expression |pattern| against the components of |field|
   // as specified in the |match_type| bit field (see |MatchType|).
   static bool Match(const AutofillField* field,
                     const base::string16& pattern,
                     int match_type);
 
   // Perform a "pass" over the |fields| where each pass uses the supplied
   // |parse| method to match content to a given field type.
   // |fields| is both an input and an output parameter.  Upon exit |fields|
   // holds any remaining unclassified fields for further processing.
   // Classification results of the processed fields are stored in |map|.
-  static void ParseFormFieldsPass(ParseFunction parse,
-                                  std::vector<AutofillField*>* fields,
-                                  ServerFieldTypeMap* map);
+  // Returns the number of recognized fields.
+  static size_t ParseFormFieldsPass(ParseFunction parse,
+                                    std::vector<AutofillField*>* fields,
+                                    ServerFieldTypeMap* map);
 
   // Returns true iff |type| matches |match_type|.
   static bool MatchesFormControlType(const std::string& type, int match_type);
 
   DISALLOW_COPY_AND_ASSIGN(FormField);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_FIELD_H_