Autofill: Set requirements for number of recognized fields in an autofillable form

components/autofill/core/browser/form_field.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/form_field.h"
 
 #include <stddef.h>
 #include <string>
 #include <utility>
 
@@ skipping 22 matching lines @@
   // Ignore fields marked as presentational. See
   // http://www.w3.org/TR/wai-aria/roles#presentation
   return field->is_checkable ||
          field->role == FormFieldData::ROLE_ATTRIBUTE_PRESENTATION;
 }
 
 }  // namespace
 
 // static
 void FormField::ParseFormFields(const std::vector<AutofillField*>& fields,
+                                bool is_form_tag,
                                 ServerFieldTypeMap* map) {
+  DCHECK(map->empty());
+
   // Set up a working copy of the fields to be processed.
   std::vector<AutofillField*> remaining_fields(fields.size());
   std::copy(fields.begin(), fields.end(), remaining_fields.begin());
 
   remaining_fields.erase(
       std::remove_if(remaining_fields.begin(), remaining_fields.end(),
                      ShouldBeIgnored),
       remaining_fields.end());
 
+  ServerFieldTypeMap saved_map = *map;
+
   // Email pass.
   ParseFormFieldsPass(EmailField::Parse, &remaining_fields, map);
+  size_t email_count = map->size();
 
   // Phone pass.
   ParseFormFieldsPass(PhoneField::Parse, &remaining_fields, map);
 
   // Address pass.
   ParseFormFieldsPass(AddressField::Parse, &remaining_fields, map);
 
   // Credit card pass.
   ParseFormFieldsPass(CreditCardField::Parse, &remaining_fields, map);
 
   // Name pass.
   ParseFormFieldsPass(NameField::Parse, &remaining_fields, map);
+
+  // Do not autofill a form if there are less than 3 recognized fields.
+  // Otherwise it is very easy to have false positives. http://crbug.com/447332
+  // For <form> tags, make an exception for email fields, which are commonly the
+  // only recognized field on account registration sites.

[Ilya Sherman, 2015/01/28 19:30:23]

Why does this apply only for <form> tags?  Are account registration forms less
likely to be implemented as <form>-less forms?  Is there a risk to treating
email forms uniformly for every form-like bag of fields that Autofill sees?

[Lei Zhang, 2015/01/28 19:46:42]

Treating email fields uniformly risks more bugs like the one you filed, but with
email as the keyword instead of address. I added the email field exception for
the ~4 registration test cases that are in <form> tags, and there are only 1 or
2 recognized fields. Many registration forms just want something like email +
zip code.

+  size_t kThreshold = 3;
+  bool accept_parsing = (map->size() >= kThreshold ||
+                         (is_form_tag && email_count > 0));
+  if (!accept_parsing)
+    *map = saved_map;
 }
 
 // static
 bool FormField::ParseField(AutofillScanner* scanner,
                            const base::string16& pattern,
                            AutofillField** match) {
   return ParseFieldSpecifics(scanner, pattern, MATCH_DEFAULT, match);
 }
 
 // static
@@ skipping 46 matching lines @@
   }
 
   return false;
 }
 
 // static
 bool FormField::Match(const AutofillField* field,
                       const base::string16& pattern,
                       int match_type) {
   if ((match_type & FormField::MATCH_LABEL) &&
-      autofill::MatchesPattern(field->label, pattern)) {
+      MatchesPattern(field->label, pattern)) {
     return true;
   }
 
   if ((match_type & FormField::MATCH_NAME) &&
-      autofill::MatchesPattern(field->name, pattern)) {
+      MatchesPattern(field->name, pattern)) {
     return true;
   }
 
   if ((match_type & FormField::MATCH_VALUE) &&
-      autofill::MatchesPattern(field->value, pattern)) {
+      MatchesPattern(field->value, pattern)) {
     return true;
   }
 
   return false;
 }
 
 // static
 void FormField::ParseFormFieldsPass(ParseFunction parse,
                                     std::vector<AutofillField*>* fields,
                                     ServerFieldTypeMap* map) {
@@ skipping 34 matching lines @@
   if ((match_type & MATCH_TEXT_AREA) && type == "textarea")
     return true;
 
   if ((match_type & MATCH_PASSWORD) && type == "password")
     return true;
 
   return false;
 }
 
 }  // namespace autofill