chrome/test/data/autofill/heuristics/output/bug_447332.out - Issue 853523004: Autofill: Set requirements for number of recognized fields in an autofillable form

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/autofill/heuristics/output/bug_447332.out

Issue 853523004: Autofill: Set requirements for number of recognized fields in an autofillable form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, change variable name Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/test/data/autofill/heuristics/input/bug_447332.html ('k') | components/autofill/content/common/autofill_param_traits_macros.h » ('j') | components/autofill/core/browser/form_field.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 UNKNOWN_TYPE \| test0 \| I intend to address this \| \| test0_1-default

	2 UNKNOWN_TYPE \| test1 \| I can haz city \| \| test0_1-default

	3 UNKNOWN_TYPE \| test2 \| State your intentions \| \| test0_1-default
	Ilya Sherman 2015/01/28 19:30:23 Why are these all parsed as unknown, if we need at Why are these all parsed as unknown, if we need at least three fields to detect a form as autofillable? There are three "gotcha" fields, afaict. Is there an off-by-one error somewhere, or is this test not quite testing what you'd intended for it to test? Lei Zhang 2015/01/28 19:46:42 The input fields are <textarea>'s just like on Goo Show quoted text On 2015/01/28 19:30:23, Ilya Sherman wrote: > Why are these all parsed as unknown, if we need at least three fields to detect > a form as autofillable? There are three "gotcha" fields, afaict. Is there an > off-by-one error somewhere, or is this test not quite testing what you'd > intended for it to test? The input fields are <textarea>'s just like on Google Docs. Autofill only looks for addresses in <textarea> tags, but not city/state. Thus the input really parses to HOME_ADDRESS/UNKNOWN/UNKNOWN/UNKNOWN, which then gets rejected.
	4 UNKNOWN_TYPE \| test3 \| Test3 \| \| test0_1-default

OLD	NEW