Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Side by Side Diff: components/autofill/core/browser/form_field_unittest.cc

Issue 853523004: Autofill: Set requirements for number of recognized fields in an autofillable form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bug, adjust tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_vector.h" 5 #include "base/memory/scoped_vector.h"
6 #include "base/strings/string16.h" 6 #include "base/strings/string16.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "components/autofill/core/browser/autofill_field.h" 8 #include "components/autofill/core/browser/autofill_field.h"
9 #include "components/autofill/core/browser/form_field.h" 9 #include "components/autofill/core/browser/form_field.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 133
134 field_data.is_checkable = true; 134 field_data.is_checkable = true;
135 field_data.label = ASCIIToUTF16("Is PO Box"); 135 field_data.label = ASCIIToUTF16("Is PO Box");
136 fields.push_back(new AutofillField(field_data, field_data.label)); 136 fields.push_back(new AutofillField(field_data, field_data.label));
137 137
138 // reset is_checkable to false. 138 // reset is_checkable to false.
139 field_data.is_checkable = false; 139 field_data.is_checkable = false;
140 field_data.label = ASCIIToUTF16("Address line2"); 140 field_data.label = ASCIIToUTF16("Address line2");
141 fields.push_back(new AutofillField(field_data, field_data.label)); 141 fields.push_back(new AutofillField(field_data, field_data.label));
142 142
143 // Have a non-address field so the form parses successfully.
144 field_data.label = ASCIIToUTF16("City");
145 fields.push_back(new AutofillField(field_data, field_data.label));
146
143 ServerFieldTypeMap field_type_map; 147 ServerFieldTypeMap field_type_map;
144 FormField::ParseFormFields(fields.get(), &field_type_map); 148 FormField::ParseFormFields(fields.get(), &field_type_map);
145 // Checkable element shouldn't interfere with inference of Address line2. 149 // Checkable element shouldn't interfere with inference of Address line2.
146 EXPECT_EQ(2U, field_type_map.size()); 150 ASSERT_EQ(3U, field_type_map.size());
147 151
148 EXPECT_EQ(ADDRESS_HOME_LINE1, 152 EXPECT_EQ(ADDRESS_HOME_LINE1,
149 field_type_map.find(ASCIIToUTF16("Address line1"))->second); 153 field_type_map.find(ASCIIToUTF16("Address line1"))->second);
150 EXPECT_EQ(ADDRESS_HOME_LINE2, 154 EXPECT_EQ(ADDRESS_HOME_LINE2,
151 field_type_map.find(ASCIIToUTF16("Address line2"))->second); 155 field_type_map.find(ASCIIToUTF16("Address line2"))->second);
152 } 156 }
153 157
154 } // namespace autofill 158 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698