Autofill: Set requirements for number of recognized fields in an autofillable form

components/autofill/core/browser/address_field_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/address_field.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/autofill_scanner.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::ASCIIToUTF16;
 
 namespace autofill {
 
 class AddressFieldTest : public testing::Test {
  public:
   AddressFieldTest() {}
 
  protected:
-  ScopedVector<AutofillField> list_;
-  scoped_ptr<AddressField> field_;
-  ServerFieldTypeMap field_type_map_;
-
   // Downcast for tests.
   static scoped_ptr<AddressField> Parse(AutofillScanner* scanner) {
     scoped_ptr<FormField> field = AddressField::Parse(scanner);
     return make_scoped_ptr(static_cast<AddressField*>(field.release()));
   }
 
+  void AddDummyCityField() {
+    FormFieldData field;
+    field.form_control_type = "text";
+    field.label = ASCIIToUTF16("City");
+    field.name = ASCIIToUTF16("city");
+    list_.push_back(new AutofillField(field, ASCIIToUTF16("city")));
+  }
+
+  ScopedVector<AutofillField> list_;
+  scoped_ptr<AddressField> field_;
+  ServerFieldTypeMap field_type_map_;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(AddressFieldTest);
 };
 
 TEST_F(AddressFieldTest, Empty) {
   AutofillScanner scanner(list_.get());
   field_ = Parse(&scanner);
   ASSERT_EQ(nullptr, field_.get());
 }
 
 TEST_F(AddressFieldTest, NonParse) {
   list_.push_back(new AutofillField);
   AutofillScanner scanner(list_.get());
   field_ = Parse(&scanner);
   ASSERT_EQ(nullptr, field_.get());
 }
 
 TEST_F(AddressFieldTest, ParseOneLineAddress) {
   FormFieldData field;
   field.form_control_type = "text";
 
+  // Just an address by itself will not parse successfully.
   field.label = ASCIIToUTF16("Address");
   field.name = ASCIIToUTF16("address");
   list_.push_back(new AutofillField(field, ASCIIToUTF16("addr1")));
 
+  {
+    AutofillScanner scanner(list_.get());
+    field_ = Parse(&scanner);
+    ASSERT_EQ(nullptr, field_.get());
+  }
+
+  AddDummyCityField();
   AutofillScanner scanner(list_.get());
   field_ = Parse(&scanner);
   ASSERT_NE(nullptr, field_.get());
+
   ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
   ASSERT_TRUE(
       field_type_map_.find(ASCIIToUTF16("addr1")) != field_type_map_.end());
   EXPECT_EQ(ADDRESS_HOME_LINE1, field_type_map_[ASCIIToUTF16("addr1")]);
 }
 
 TEST_F(AddressFieldTest, ParseTwoLineAddress) {
   FormFieldData field;
   field.form_control_type = "text";
 
   field.label = ASCIIToUTF16("Address");
   field.name = ASCIIToUTF16("address");
   list_.push_back(new AutofillField(field, ASCIIToUTF16("addr1")));
 
   field.label = base::string16();
   field.name = ASCIIToUTF16("address2");
   list_.push_back(new AutofillField(field, ASCIIToUTF16("addr2")));
 
+  AddDummyCityField();
   AutofillScanner scanner(list_.get());
   field_ = Parse(&scanner);
   ASSERT_NE(nullptr, field_.get());
   ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
   ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("addr1")) !=
               field_type_map_.end());
   EXPECT_EQ(ADDRESS_HOME_LINE1, field_type_map_[ASCIIToUTF16("addr1")]);
   ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("addr2")) !=
               field_type_map_.end());
   EXPECT_EQ(ADDRESS_HOME_LINE2, field_type_map_[ASCIIToUTF16("addr2")]);
 }
 
 TEST_F(AddressFieldTest, ParseThreeLineAddress) {
   FormFieldData field;
   field.form_control_type = "text";
 
   field.label = ASCIIToUTF16("Address Line1");
   field.name = ASCIIToUTF16("Address1");
   list_.push_back(new AutofillField(field, ASCIIToUTF16("addr1")));
 
   field.label = ASCIIToUTF16("Address Line2");
   field.name = ASCIIToUTF16("Address2");
   list_.push_back(new AutofillField(field, ASCIIToUTF16("addr2")));
 
   field.label = ASCIIToUTF16("Address Line3");
   field.name = ASCIIToUTF16("Address3");
   list_.push_back(new AutofillField(field, ASCIIToUTF16("addr3")));
 
+  AddDummyCityField();
   AutofillScanner scanner(list_.get());
   field_ = Parse(&scanner);
   ASSERT_NE(nullptr, field_.get());
   ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
   ASSERT_TRUE(
       field_type_map_.find(ASCIIToUTF16("addr1")) != field_type_map_.end());
   EXPECT_EQ(ADDRESS_HOME_LINE1, field_type_map_[ASCIIToUTF16("addr1")]);
   ASSERT_TRUE(
       field_type_map_.find(ASCIIToUTF16("addr2")) != field_type_map_.end());
   EXPECT_EQ(ADDRESS_HOME_LINE2, field_type_map_[ASCIIToUTF16("addr2")]);
   ASSERT_TRUE(
       field_type_map_.find(ASCIIToUTF16("addr3")) != field_type_map_.end());
   EXPECT_EQ(ADDRESS_HOME_LINE3, field_type_map_[ASCIIToUTF16("addr3")]);
 }
 
 TEST_F(AddressFieldTest, ParseStreetAddressFromTextArea) {
   FormFieldData field;
   field.form_control_type = "textarea";
 
   field.label = ASCIIToUTF16("Address");
   field.name = ASCIIToUTF16("address");
   list_.push_back(new AutofillField(field, ASCIIToUTF16("addr")));
 
+  AddDummyCityField();
   AutofillScanner scanner(list_.get());
   field_ = Parse(&scanner);
   ASSERT_NE(nullptr, field_.get());
   ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
   ASSERT_TRUE(
       field_type_map_.find(ASCIIToUTF16("addr")) != field_type_map_.end());
   EXPECT_EQ(ADDRESS_HOME_STREET_ADDRESS, field_type_map_[ASCIIToUTF16("addr")]);
 }
 
 TEST_F(AddressFieldTest, ParseCity) {
@@ skipping 99 matching lines @@
   AutofillScanner scanner(list_.get());
   field_ = Parse(&scanner);
   ASSERT_NE(nullptr, field_.get());
   ASSERT_TRUE(field_->ClassifyField(&field_type_map_));
   ASSERT_TRUE(
       field_type_map_.find(ASCIIToUTF16("company1")) != field_type_map_.end());
   EXPECT_EQ(COMPANY_NAME, field_type_map_[ASCIIToUTF16("company1")]);
 }
 
 }  // namespace autofill