Autofill: Set requirements for number of recognized fields in an autofillable form

components/autofill/core/browser/autofill_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/memory/ref_counted.h"
@@ skipping 69 matching lines @@
   }
 
   void AddProfile(AutofillProfile* profile) {
     web_profiles_.push_back(profile);
   }
 
   void AddCreditCard(CreditCard* credit_card) {
     local_credit_cards_.push_back(credit_card);
   }
 
-  virtual void RemoveByGUID(const std::string& guid) override {
+  void RemoveByGUID(const std::string& guid) override {
     CreditCard* credit_card = GetCreditCardWithGUID(guid.c_str());
     if (credit_card) {
       local_credit_cards_.erase(
           std::find(local_credit_cards_.begin(), local_credit_cards_.end(),
                     credit_card));
     }
 
     AutofillProfile* profile = GetProfileWithGUID(guid.c_str());
     if (profile) {
       web_profiles_.erase(
           std::find(web_profiles_.begin(), web_profiles_.end(), profile));
     }
   }
 
   // Do nothing (auxiliary profiles will be created in
   // CreateTestAuxiliaryProfile).
-  virtual void LoadAuxiliaryProfiles(bool record_metrics) const override {}
+  void LoadAuxiliaryProfiles(bool record_metrics) const override {}
 
   void ClearAutofillProfiles() {
     web_profiles_.clear();
   }
 
   void ClearCreditCards() {
     local_credit_cards_.clear();
   }
 
   void CreateTestAuxiliaryProfiles() {
@@ skipping 520 matching lines @@
                               const FormFieldData& field) {
     GetAutofillSuggestions(kDefaultPageID, form, field);
   }
 
   void AutocompleteSuggestionsReturned(
       const std::vector<base::string16>& result) {
     autofill_manager_->autocomplete_history_manager_->SendSuggestions(&result);
   }
 
   void FormsSeen(const std::vector<FormData>& forms) {
-    autofill_manager_->OnFormsSeen(forms, base::TimeTicks());
+    autofill_manager_->OnFormsSeen(forms, false, base::TimeTicks());
   }
 
   void FormSubmitted(const FormData& form) {
     autofill_manager_->ResetRunLoop();
     if (autofill_manager_->OnFormSubmitted(form, base::TimeTicks::Now()))
       autofill_manager_->WaitForAsyncFormSubmit();
   }
 
   void FillAutofillFormData(int query_id,
                             const FormData& form,
@@ skipping 88 matching lines @@
 // Test that we return only matching address profile suggestions when the
 // selected form field has been partially filled out.
 TEST_F(AutofillManagerTest, GetProfileSuggestionsMatchCharacter) {
   // Set up our form data.
   FormData form;
   test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   FormFieldData field;
-  test::CreateTestFormField("First Name", "firstname", "E", "text",&field);
+  test::CreateTestFormField("First Name", "firstname", "E", "text", &field);
   GetAutofillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
 
   // Test that we sent the right values to the external delegate.
   external_delegate_->CheckSuggestions(
       kDefaultPageID,
       Suggestion("Elvis", "3734 Elvis Presley Blvd.", "", 1));
 }
 
 // Test that we return no suggestions when the form has no relevant fields.
 TEST_F(AutofillManagerTest, GetProfileSuggestionsUnknownFields) {
   // Set up our form data.
   FormData form;
   form.name = ASCIIToUTF16("MyForm");
   form.origin = GURL("http://myform.com/form.html");
   form.action = GURL("http://myform.com/submit.html");
   form.user_submitted = true;
 
   FormFieldData field;
-  test::CreateTestFormField("Username", "username", "", "text",&field);
+  test::CreateTestFormField("Username", "username", "", "text", &field);
   form.fields.push_back(field);
-  test::CreateTestFormField("Password", "password", "", "password",&field);
+  test::CreateTestFormField("Password", "password", "", "password", &field);
   form.fields.push_back(field);
   test::CreateTestFormField("Quest", "quest", "", "quest", &field);
   form.fields.push_back(field);
   test::CreateTestFormField("Color", "color", "", "text", &field);
   form.fields.push_back(field);
 
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   GetAutofillSuggestions(form, field);
@@ skipping 526 matching lines @@
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
 
   // Test that we sent the right values to the external delegate. Inferred
   // labels include full first relevant field, which in this case is the
   // address line 1.
   external_delegate_->CheckSuggestions(
       kDefaultPageID,
       Suggestion("12345678901", "Elvis Aaron Presley", "", 1),
       Suggestion("23456789012", "Charles Hardin Holley", "", 2),
       Suggestion("18007724743", "Natty Bumppo", "", 3));  // 1800PRAIRIE
-
 }
 
 TEST_F(AutofillManagerTest, GetProfileSuggestionsForPhonePrefixOrSuffix) {
   // Set up our form data.
   FormData form;
   form.name = ASCIIToUTF16("MyForm");
   form.origin = GURL("http://myform.com/form.html");
   form.action = GURL("http://myform.com/submit.html");
   form.user_submitted = true;
 
@@ skipping 1425 matching lines @@
 
   SuggestionBackendID guid_pair(guid, 0);
   SuggestionBackendID empty(std::string(), 0);
   int id = MakeFrontendID(empty, guid_pair);
 
   autofill_manager_->RemoveAutofillProfileOrCreditCard(id);
 
   EXPECT_FALSE(autofill_manager_->GetProfileWithGUID(guid.c_str()));
 }
 
-TEST_F(AutofillManagerTest, RemoveCreditCard){
+TEST_F(AutofillManagerTest, RemoveCreditCard) {
   // Add and remove an Autofill credit card.
   CreditCard* credit_card = new CreditCard;
   std::string guid = "00000000-0000-0000-0000-000000100007";
   credit_card->set_guid(guid.c_str());
   autofill_manager_->AddCreditCard(credit_card);
 
   SuggestionBackendID guid_pair(guid, 0);
   SuggestionBackendID empty(std::string(), 0);
   int id = MakeFrontendID(guid_pair, empty);
 
@@ skipping 140 matching lines @@
   // results. This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
 
   external_delegate_->CheckSuggestions(
       kDefaultPageID,
       Suggestion("Visa - 3456", "04/12", kVisaCard,
                  autofill_manager_->GetPackedCreditCardID(4)));
 }
 
 }  // namespace autofill