Fix ThreadChecker bug in WeakNSObject

base/ios/weak_nsobject.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_IOS_WEAK_NSOBJECT_H_
 #define BASE_IOS_WEAK_NSOBJECT_H_
 
 #import <Foundation/Foundation.h>
 #import <objc/runtime.h>
 
@@ skipping 19 matching lines @@
 //   foo.reset();  // The reference is released.
 //   [weak_foo description];  // Returns nil, as weak_foo is pointing to nil.
 //
 //
 // Implementation wise a WeakNSObject keeps a reference to a refcounted
 // WeakContainer. There is one unique instance of a WeakContainer per watched
 // NSObject, this relationship is maintained via the ObjectiveC associated
 // object API, indirectly via an ObjectiveC CRBWeakNSProtocolSentinel class.
 //
 // The implementation assumes that the tracked object will be released on the
 // same thread that the WeakNSObject is created on.

[lliabraa, 2015/01/14 15:25:00]

how about expanding this section on threading with examples of what's allowed
and what's not?

 //
 namespace base {
 
 // WeakContainer keeps a weak pointer to an object and clears it when it
 // receives nullify() from the object's sentinel.
 class WeakContainer : public base::RefCountedThreadSafe<WeakContainer> {
  public:
-  WeakContainer(id object) : object_(object) {}
-  id object() { return object_; }
+  explicit WeakContainer(id object) : object_(object) {}
+
+  id object() {
+    DCHECK(checker_.CalledOnValidThread());
+    return object_;
+  }
+
   void nullify() {
     DCHECK(checker_.CalledOnValidThread());
     object_ = nil;
   }
 
  private:
   friend base::RefCountedThreadSafe<WeakContainer>;
   ~WeakContainer() {}
   base::ThreadChecker checker_;
   id object_;
 };
 
 }  // namespace base
 
 // Sentinel for observing the object contained in the weak pointer. The object
 // will be deleted when the weak object is deleted and will notify its
 // container.
 @interface CRBWeakNSProtocolSentinel : NSObject
 // Return the only associated container for this object. There can be only one.
 // Will return null if object is nil .
 + (scoped_refptr<base::WeakContainer>)containerForObject:(id)object;
 @end
 
 namespace base {
 
 // Base class for all WeakNSObject derivatives.
 template <typename NST>
-class WeakNSProtocol : public base::NonThreadSafe {
+class WeakNSProtocol {
  public:
   explicit WeakNSProtocol(NST object = nil) {
+    // A WeakNSProtocol object can be allocated on one thread and used on
+    // another. This is not the case for the contained object.
+    checker_.DetachFromThread();

[lliabraa, 2015/01/14 15:25:00]

won't calling DetachFromThread() here cause the WeakNSObject to not be
associated with any thread when it's created? Seems like we only want to call
DetachFromThread() in the copy constructor.

     container_ = [CRBWeakNSProtocolSentinel containerForObject:object];
   }
 
   WeakNSProtocol(const WeakNSProtocol<NST>& that) {
+    // A WeakNSProtocol object can be allocated on one thread and used on
+    // another. This is not the case for the contained object.
+    checker_.DetachFromThread();
     container_ = that.container_;
   }
 
   ~WeakNSProtocol() {
-    // A WeakNSProtocol object can be allocated on one thread and released on
+    // A WeakNSProtocol object can be used on one thread and released on
     // another. This is not the case for the contained object.
-    DetachFromThread();
+    checker_.DetachFromThread();
   }
 
   void reset(NST object = nil) {
-    DCHECK(CalledOnValidThread());
+    DCHECK(checker_.CalledOnValidThread());
     container_ = [CRBWeakNSProtocolSentinel containerForObject:object];
   }
 
   NST get() const {
-    DCHECK(CalledOnValidThread());
+    DCHECK(checker_.CalledOnValidThread());
     if (!container_.get())
       return nil;
     return container_->object();
   }
 
   WeakNSProtocol& operator=(const WeakNSProtocol<NST>& that) {
-    DCHECK(CalledOnValidThread());
+    DCHECK(checker_.CalledOnValidThread());
     container_ = that.container_;
     return *this;
   }
 
   bool operator==(NST that) const {
-    DCHECK(CalledOnValidThread());
+    DCHECK(checker_.CalledOnValidThread());
     return get() == that;
   }
 
-  bool operator!=(NST that) const { return get() != that; }
+  bool operator!=(NST that) const {
+    DCHECK(checker_.CalledOnValidThread());
+    return get() != that;
+  }
 
-  operator NST() const { return get(); }
+  operator NST() const {
+    DCHECK(checker_.CalledOnValidThread());
+    return get();
+  }
 
  private:
   // Refecounted reference to the container tracking the ObjectiveC object this
   // class encapsulates.
   scoped_refptr<base::WeakContainer> container_;
+  base::ThreadChecker checker_;
 };
 
 // Free functions
 template <class NST>
 bool operator==(NST p1, const WeakNSProtocol<NST>& p2) {
   return p1 == p2.get();
 }
 
 template <class NST>
 bool operator!=(NST p1, const WeakNSProtocol<NST>& p2) {
@@ skipping 23 matching lines @@
 
   WeakNSObject& operator=(const WeakNSObject<id>& that) {
     WeakNSProtocol<id>::operator=(that);
     return *this;
   }
 };
 
 }  // namespace base
 
 #endif  // BASE_IOS_WEAK_NSOBJECT_H_