Add support for 'display-mode' MQ defined in Manifest spec

Add support for 'display-mode' MQ defined in Manifest spec

http://w3c.github.io/manifest/#the-display-mode-media-feature

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188729

[kenneth.r.christiansen, 2015-01-13 13:35:05]

kenneth.r.christiansen@intel.com changed reviewers:
+ mkwst@chromium.org, yoav@yoav.ws

[kenneth.r.christiansen, 2015-01-13 13:35:06]

Hey Yoav, I am still fighting with the cache unit test, could you have a look?

[Mike West, 2015-01-13 13:49:46]

mkwst@chromium.org changed required reviewers:
+ yoav@yoav.ws

[Mike West, 2015-01-13 13:49:47]

I'd like to defer this to Yoav. If he doesn't have time, I'll be happy to take a
look.

[Yoav Weiss, 2015-01-13 14:11:10]

On 2015/01/13 13:49:47, Mike West wrote:
> I'd like to defer this to Yoav. If he doesn't have time, I'll be happy to take
a
> look.

I'll take a look at this during the day

[Yoav Weiss, 2015-01-13 21:04:47]

On 2015/01/13 14:11:10, Yoav Weiss wrote:
> On 2015/01/13 13:49:47, Mike West wrote:
> > I'd like to defer this to Yoav. If he doesn't have time, I'll be happy to
take
> a
> > look.
> 
> I'll take a look at this during the day

The code looks good :)
Was this feature covered by an "intent to ship" email?

[kenneth.r.christiansen, 2015-01-13 21:11:00]

On 2015/01/13 at 21:04:47, yoav wrote:
> On 2015/01/13 14:11:10, Yoav Weiss wrote:
> > On 2015/01/13 13:49:47, Mike West wrote:
> > > I'd like to defer this to Yoav. If he doesn't have time, I'll be happy to
take
> > a
> > > look.
> > 
> > I'll take a look at this during the day
> 
> The code looks good :)
> Was this feature covered by an "intent to ship" email?

As I read it it covers the whole feature (what is in the spec), so I would sat
yes.

[kenneth.christiansen, 2015-01-14 10:41:48]

> > The code looks good :)
> > Was this feature covered by an "intent to ship" email?
> 
> As I read it it covers the whole feature (what is in the spec), so I would sat
> yes.

Mike, could you do the official review? Code looks good to Yoav

[Yoav Weiss, 2015-01-14 12:12:33]

On 2015/01/13 21:11:00, kenneth.r.christiansen wrote:
> On 2015/01/13 at 21:04:47, yoav wrote:
> > On 2015/01/13 14:11:10, Yoav Weiss wrote:
> > > On 2015/01/13 13:49:47, Mike West wrote:
> > > > I'd like to defer this to Yoav. If he doesn't have time, I'll be happy
to
> take
> > > a
> > > > look.
> > > 
> > > I'll take a look at this during the day
> > 
> > The code looks good :)
> > Was this feature covered by an "intent to ship" email?
> 
> As I read it it covers the whole feature (what is in the spec), so I would sat
> yes.

LGTM then :)

[Yoav Weiss, 2015-01-14 12:29:18]

On 2015/01/14 12:12:33, Yoav Weiss wrote:
> On 2015/01/13 21:11:00, kenneth.r.christiansen wrote:
> > On 2015/01/13 at 21:04:47, yoav wrote:
> > > On 2015/01/13 14:11:10, Yoav Weiss wrote:
> > > > On 2015/01/13 13:49:47, Mike West wrote:
> > > > > I'd like to defer this to Yoav. If he doesn't have time, I'll be happy
> to
> > take
> > > > a
> > > > > look.
> > > > 
> > > > I'll take a look at this during the day
> > > 
> > > The code looks good :)
> > > Was this feature covered by an "intent to ship" email?
> > 
> > As I read it it covers the whole feature (what is in the spec), so I would
sat
> > yes.
> 
> LGTM then :)

Going over the "intent to ship" thread, it's probably covered, but it might be a
good idea to send out a PSA making this change explicit.

[kenneth.r.christiansen, 2015-01-21 09:00:58]

The CQ bit was checked by kenneth.r.christiansen@intel.com

[commit-bot: I haz the power, 2015-01-21 09:01:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/853483003/60001

[commit-bot: I haz the power, 2015-01-21 10:16:48]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188729