Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 853433002: Remove Document::shouldScheduleLayout. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove Document::shouldScheduleLayout. All it does is call isActive() now. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5ca7d0d7707abb9878ff14869ee73aa99ddeb11b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove redundant call. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M sky/engine/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 2 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
esprehn
5 years, 11 months ago (2015-01-13 06:42:35 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/853433002/diff/1/sky/engine/core/dom/Document.cpp File sky/engine/core/dom/Document.cpp (right): https://codereview.chromium.org/853433002/diff/1/sky/engine/core/dom/Document.cpp#newcode946 sky/engine/core/dom/Document.cpp:946: return true; return isActive()
5 years, 11 months ago (2015-01-13 07:17:41 UTC) #4
esprehn
https://codereview.chromium.org/853433002/diff/1/sky/engine/core/dom/Document.cpp File sky/engine/core/dom/Document.cpp (right): https://codereview.chromium.org/853433002/diff/1/sky/engine/core/dom/Document.cpp#newcode946 sky/engine/core/dom/Document.cpp:946: return true; On 2015/01/13 at 07:17:41, abarth wrote: > ...
5 years, 11 months ago (2015-01-13 07:31:29 UTC) #5
esprehn
5 years, 11 months ago (2015-01-13 07:32:17 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
5ca7d0d7707abb9878ff14869ee73aa99ddeb11b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698