Issue 85343005: Revert 237242 "Linux sandbox: move CurrentProcessHasOpenDirectories"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 85343005: Revert 237242 "Linux sandbox: move CurrentProcessHasOpenDirectories" (Closed)

Created:
7 years ago by jln (very slow on Chromium)

Modified:
7 years ago

Reviewers:
jln (very slow on Chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 237242 "Linux sandbox: move CurrentProcessHasOpenDirectories" > Linux sandbox: move CurrentProcessHasOpenDirectories > > Move CurrentProcessHasOpenDirectories() to the Credentials class and rename > it to HasOpenDirectory(). > Also add some unittests. > > BUG=312380 > R=jorgelo@chromium.org > > Review URL: https://codereview.chromium.org/85403011 TBR=jln@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237251

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -123 lines)			Patch
M	trunk/src/content/common/sandbox_linux.cc	View	3 chunks	+56 lines, -2 lines	0 comments	Download
M	trunk/src/sandbox/linux/services/credentials.h	View	2 chunks	+3 lines, -16 lines	0 comments	Download
M	trunk/src/sandbox/linux/services/credentials.cc	View	4 chunks	+0 lines, -61 lines	0 comments	Download
M	trunk/src/sandbox/linux/services/credentials_unittest.cc	View	2 chunks	+0 lines, -44 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r237251.