tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py - Issue 853353005: [Telemetry] Add tracing_agent API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

Issue 853353005: [Telemetry] Add tracing_agent API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unittest breakage (bug in tracing_controller_backend) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/measurements/smoothness_unittest.py ('k') | tools/telemetry/telemetry/core/platform/tracing_agent/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

index c79857c74279be1a9faac2cd6748b08badf45755..96356370ddd6586c93f162d4aa1ca2f1d476a823 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

@@ -6,10 +6,11 @@ import logging

import re

from telemetry import decorators

+from telemetry.timeline import trace_data as trace_data_module

from telemetry.core.backends.chrome_inspector import devtools_http

from telemetry.core.backends.chrome_inspector import inspector_backend

from telemetry.core.backends.chrome_inspector import tracing_backend

-from telemetry.timeline import trace_data as trace_data_module

+from telemetry.core.platform.tracing_agent import chrome_tracing_agent

def IsDevToolsAgentAvailable(port):

@@ -48,10 +49,10 @@ class DevToolsClientBackend(object):

self._devtools_context_map_backend = _DevToolsContextMapBackend(

self._app_backend, self)

- tracing_controller_backend = (

- self._app_backend.platform_backend.tracing_controller_backend)

- tracing_controller_backend.RegisterDevToolsClient(self)

+ chrome_tracing_agent.ChromeTracingAgent.RegisterDevToolsClient(

+ self, self._app_backend.platform_backend)

+ @property

def remote_port(self):

return self._remote_devtools_port