Begin the redesign process, starting with the navbar.

Begin the redesign process, starting with the navbar.

[Andrei Mouravski, 2013-11-26 00:26:42]

Sorry that this CL is so wonky. I had some issues with getting it working. :[

[Bob Nystrom, 2013-11-26 19:00:10]

https://codereview.chromium.org/85333007/diff/1/README.md
File README.md (right):

https://codereview.chromium.org/85333007/diff/1/README.md#newcode10
README.md:10: │   ├───┬ doc/                Documentation and articles.
"Source markdown for documentation"

https://codereview.chromium.org/85333007/diff/1/README.md#newcode22
README.md:22: │   │   └──── style.css       Generated stylesheet. Modify
/stylesheets/style.scss instead.
Long line, here and below.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode25
README.md:25: │   │   ├───┬ doc/            Generated HTML. Modify /app/doc/
files instead.
Ditto.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode35
README.md:35: │       ├──── _syntax.scss    Dart language syntax styles.
Technically, this applies to other languages too, right? How about just "Syntax
highlighting styles."

https://codereview.chromium.org/85333007/diff/1/README.md#newcode42
README.md:42: ├───┬ third_party/            External dependencies to be include
in the app.
"to be include in" -> "used by"

https://codereview.chromium.org/85333007/diff/1/README.md#newcode47
README.md:47: ├──── test.py                 Tests the app.
"Runs all tests."

https://codereview.chromium.org/85333007/diff/1/README.md#newcode61
README.md:61: * Install required packages.<sup>2</sup>
Convert the other bullets to numeric too.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode98
README.md:98: ## Deploying to the web
"the web" -> "production"

https://codereview.chromium.org/85333007/diff/1/README.md#newcode109
README.md:109: [Jekyll][].
Long lines.

https://codereview.chromium.org/85333007/diff/1/app/static/style.css
File app/static/style.css (right):

https://codereview.chromium.org/85333007/diff/1/app/static/style.css#newcode252
app/static/style.css:252: .btn-default,
Is all of this dropped from bootstrap? Dartlang.org? Both? Can it be separated
out so it's clear which things are specific to pub and which things we should be
able to take new drops from?

https://codereview.chromium.org/85333007/diff/1/app/views/layout.mustache
File app/views/layout.mustache (right):

https://codereview.chromium.org/85333007/diff/1/app/views/layout.mustache#new...
app/views/layout.mustache:96: <h3>FOOBAR{{message}}</h3>
?

https://codereview.chromium.org/85333007/diff/1/stylesheets/partials/_syntax....
File stylesheets/partials/_syntax.scss (right):

https://codereview.chromium.org/85333007/diff/1/stylesheets/partials/_syntax....
stylesheets/partials/_syntax.scss:5: // These styles come from
https://github.com/dart-lang/dartlang.org/blob/master/src/site/scss/_syntax.scss.
Are they still up to date?

https://codereview.chromium.org/85333007/diff/1/stylesheets/partials/_variabl...
File stylesheets/partials/_variables.scss (right):

https://codereview.chromium.org/85333007/diff/1/stylesheets/partials/_variabl...
stylesheets/partials/_variables.scss:206: // Note: Deprecated $screen-xs and
$screen-phone as of v3.0.1
Might as well delete the deprecated ones since we aren't using them.

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss
File stylesheets/style.scss (right):

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss#newcode12
stylesheets/style.scss:12: //// Don't require nasty <table class="table"> that
bootstrap expects.
Why ////?

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss#newcode21
stylesheets/style.scss:21: //$iconWhiteSpritePath:
'img/glyphicons-halflings-white.png';
If they're commented out, can you chuck them now?

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss#newcode47
stylesheets/style.scss:47: // TODO(amouravski): Spruce up search box.
These are distinct enough that it probably makes more sense just to file bugs
for them.

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss#newcode97
stylesheets/style.scss:97: //}
Delete all this commented out stuff.

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss#newcod...
stylesheets/style.scss:255: //}
You should fix this before the patch goes in. I know the admin page matters
less, but there's no rush so we may as well not regress functionality.

[nweiz, 2013-11-27 00:58:59]

https://codereview.chromium.org/85333007/diff/1/README.md
File README.md (right):

https://codereview.chromium.org/85333007/diff/1/README.md#newcode22
README.md:22: │   │   └──── style.css       Generated stylesheet. Modify
/stylesheets/style.scss instead.
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> Long line, here and below.

I think long lines in code blocks are reasonable if they look okay in the
compiled output.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode55
README.md:55: ### Prerequisites
Nit: newline after this.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode67
README.md:67: ### Running server
Nit: "Running the server"

https://codereview.chromium.org/85333007/diff/1/app/app.yaml
File app/app.yaml (right):

https://codereview.chromium.org/85333007/diff/1/app/app.yaml#newcode23
app/app.yaml:23: - url: /app/static/img
Why is "app" in the URL?

[Andrei Mouravski, 2013-11-29 21:21:20]

PTAL.

https://codereview.chromium.org/85333007/diff/1/README.md
File README.md (right):

https://codereview.chromium.org/85333007/diff/1/README.md#newcode10
README.md:10: │   ├───┬ doc/                Documentation and articles.
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> "Source markdown for documentation"

Done.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode22
README.md:22: │   │   └──── style.css       Generated stylesheet. Modify
/stylesheets/style.scss instead.
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> Long line, here and below.

Ack.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode22
README.md:22: │   │   └──── style.css       Generated stylesheet. Modify
/stylesheets/style.scss instead.
On 2013/11/27 00:58:59, nweiz wrote:
> On 2013/11/26 19:00:11, Bob Nystrom wrote:
> > Long line, here and below.
> 
> I think long lines in code blocks are reasonable if they look okay in the
> compiled output.

Ack.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode25
README.md:25: │   │   ├───┬ doc/            Generated HTML. Modify /app/doc/
files instead.
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> Ditto.

Ack.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode35
README.md:35: │       ├──── _syntax.scss    Dart language syntax styles.
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> Technically, this applies to other languages too, right? How about just
"Syntax
> highlighting styles."

Done.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode42
README.md:42: ├───┬ third_party/            External dependencies to be include
in the app.
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> "to be include in" -> "used by"

Done.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode47
README.md:47: ├──── test.py                 Tests the app.
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> "Runs all tests."

Done.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode55
README.md:55: ### Prerequisites
On 2013/11/27 00:58:59, nweiz wrote:
> Nit: newline after this.

Done.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode61
README.md:61: * Install required packages.<sup>2</sup>
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> Convert the other bullets to numeric too.

Done.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode67
README.md:67: ### Running server
On 2013/11/27 00:58:59, nweiz wrote:
> Nit: "Running the server"

Done.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode98
README.md:98: ## Deploying to the web
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> "the web" -> "production"

Done.

https://codereview.chromium.org/85333007/diff/1/README.md#newcode109
README.md:109: [Jekyll][].
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> Long lines.

Done.

https://codereview.chromium.org/85333007/diff/1/app/app.yaml
File app/app.yaml (right):

https://codereview.chromium.org/85333007/diff/1/app/app.yaml#newcode23
app/app.yaml:23: - url: /app/static/img
On 2013/11/27 00:58:59, nweiz wrote:
> Why is "app" in the URL?

Because there's some stupid thing where I couldn't figure out why images_path
didn't seem to give me good results in config.rb.

Instead of fighting with it further, I just shortcutted.

The issue is that it seems that compass is finding the images once, but then
doesn't write the right urls or something. Or, it DOESN'T find the right path,
and the url is right.

Some weird bug/issue that I couldn't quite figure out.

Pull requests welcome. ;]

https://codereview.chromium.org/85333007/diff/1/app/static/style.css
File app/static/style.css (right):

https://codereview.chromium.org/85333007/diff/1/app/static/style.css#newcode252
app/static/style.css:252: .btn-default,
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> Is all of this dropped from bootstrap? Dartlang.org? Both? Can it be separated
> out so it's clear which things are specific to pub and which things we should
be
> able to take new drops from?

We basically take nothing from dartlang.org. The only css that's being used is,
_syntax.scss, _variables (which just modifies bootstrap-sass), bootstrap-sass,
compass, and the other hand-written syntax.scss.

What exactly are you asking for?

https://codereview.chromium.org/85333007/diff/1/app/views/layout.mustache
File app/views/layout.mustache (right):

https://codereview.chromium.org/85333007/diff/1/app/views/layout.mustache#new...
app/views/layout.mustache:96: <h3>FOOBAR{{message}}</h3>
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> ?

Done.

https://codereview.chromium.org/85333007/diff/1/stylesheets/partials/_syntax....
File stylesheets/partials/_syntax.scss (right):

https://codereview.chromium.org/85333007/diff/1/stylesheets/partials/_syntax....
stylesheets/partials/_syntax.scss:5: // These styles come from
https://github.com/dart-lang/dartlang.org/blob/master/src/site/scss/_syntax.scss.
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> Are they still up to date?

Not sure. I'll add an issue.

https://codereview.chromium.org/85333007/diff/1/stylesheets/partials/_variabl...
File stylesheets/partials/_variables.scss (right):

https://codereview.chromium.org/85333007/diff/1/stylesheets/partials/_variabl...
stylesheets/partials/_variables.scss:206: // Note: Deprecated $screen-xs and
$screen-phone as of v3.0.1
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> Might as well delete the deprecated ones since we aren't using them.

Done.

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss
File stylesheets/style.scss (right):

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss#newcode12
stylesheets/style.scss:12: //// Don't require nasty <table class="table"> that
bootstrap expects.
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> Why ////?

:g/^/norm i//

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss#newcode21
stylesheets/style.scss:21: //$iconWhiteSpritePath:
'img/glyphicons-halflings-white.png';
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> If they're commented out, can you chuck them now?

Not yet, since I want to make sure the new stuff works first.

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss#newcode47
stylesheets/style.scss:47: // TODO(amouravski): Spruce up search box.
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> These are distinct enough that it probably makes more sense just to file bugs
> for them.

Done.

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss#newcode97
stylesheets/style.scss:97: //}
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> Delete all this commented out stuff.

Done.

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss#newcod...
stylesheets/style.scss:255: //}
On 2013/11/26 19:00:11, Bob Nystrom wrote:
> You should fix this before the patch goes in. I know the admin page matters
> less, but there's no rush so we may as well not regress functionality.

Well, this is on the dev branch. I just want to make my changes more atomic.

[Bob Nystrom, 2013-12-02 22:46:55]

LGTM assuming this is staying in a branch for now.

https://codereview.chromium.org/85333007/diff/1/app/static/style.css
File app/static/style.css (right):

https://codereview.chromium.org/85333007/diff/1/app/static/style.css#newcode252
app/static/style.css:252: .btn-default,
On 2013/11/29 21:21:21, Andrei Mouravski wrote:
> On 2013/11/26 19:00:11, Bob Nystrom wrote:
> > Is all of this dropped from bootstrap? Dartlang.org? Both? Can it be
separated
> > out so it's clear which things are specific to pub and which things we
should
> be
> > able to take new drops from?
> 
> We basically take nothing from http://dartlang.org. The only css that's being
used is,
> _syntax.scss, _variables (which just modifies bootstrap-sass), bootstrap-sass,
> compass, and the other hand-written syntax.scss.
> 
> What exactly are you asking for?

Oh, now I see my confusion here. Didn't realize I was looking at the generated
CSS from the SCSS files. Never mind then. :)

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss
File stylesheets/style.scss (right):

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss#newcode21
stylesheets/style.scss:21: //$iconWhiteSpritePath:
'img/glyphicons-halflings-white.png';
On 2013/11/29 21:21:21, Andrei Mouravski wrote:
> On 2013/11/26 19:00:11, Bob Nystrom wrote:
> > If they're commented out, can you chuck them now?
> 
> Not yet, since I want to make sure the new stuff works first.

If the new stuff doesn't work, then you shouldn't land this patch yet, right?

https://codereview.chromium.org/85333007/diff/1/stylesheets/style.scss#newcod...
stylesheets/style.scss:255: //}
On 2013/11/29 21:21:21, Andrei Mouravski wrote:
> On 2013/11/26 19:00:11, Bob Nystrom wrote:
> > You should fix this before the patch goes in. I know the admin page matters
> > less, but there's no rush so we may as well not regress functionality.
> 
> Well, this is on the dev branch. I just want to make my changes more atomic.

Ah, OK. Are you planning to work in a branch for a while before merging into
master then? If so, that's great.

What I want to ensure is that we can deploy from master at any point in time.