Issue 853303004: Add Application::RequestQuit()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 853303004: Add Application::RequestQuit() (Closed)

Created:
5 years, 11 months ago by Aaron Boodman

Modified:
5 years, 11 months ago

Reviewers:
DaveMoore

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org, ojan

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add Application::RequestQuit(). This allows an application's host (typically the shell) to request the application to gracefully shut down. There is not currently a caller. It will require additional work in application manager to do that. R=davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/991ab6de4e6e1ab2783633c4cdd9c898c462dac0

Patch Set 1 #

Patch Set 2 : Quit->RequestQuit #

Patch Set 3 : commentary #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
M	examples/content_handler_demo/content_handler_demo.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/cpp/application/application_impl.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/cpp/application/lib/application_impl.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	mojo/public/interfaces/application/application.mojom	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	shell/external_application_listener_unittest.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/viewer/content_handler_impl.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Aaron Boodman

5 years, 11 months ago (2015-01-20 21:12:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
991ab6de4e6e1ab2783633c4cdd9c898c462dac0 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages