Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3154)

Unified Diff: build/common.gypi

Issue 853293002: Upstream //build/ios/coverage.gypi (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Define enable_coverage var. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/ios/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 119f5b4b21ae0526e7037fd64bb0c6c0feb72376..8c6eb81e655d65e77ac19f529e83b24da2b00710 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2058,6 +2058,9 @@
'grit_defines': ['-D', 'scale_factors=2x'],
}],
['OS == "ios"', {
+ 'variables': {
+ 'enable_coverage%': 0,
+ },
'grit_defines': [
'-t', 'ios',
# iOS uses a whitelist to filter resources.
@@ -2073,7 +2076,10 @@
# TODO(sdefresne): Remove the target_subarch check once Apple has
# upstreamed the support for "arm64". http://crbug.com/341453
- ['target_subarch!="arm32" or "<(GENERATOR)"=="xcode"', {
+ # TODO(eugenebut): Remove enable_coverage check once
+ # libclang_rt.profile_ios.a is bundled with Chromium's clang.
+ # http://crbug.com/450379
+ ['target_subarch!="arm32" or enable_coverage or "<(GENERATOR)"=="xcode"', {
'clang_xcode%': 1,
}],
],
« no previous file with comments | « no previous file | build/ios/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698