Upstream //build/ios/coverage.gypi

build/ios/coverage.gypi

Index: build/ios/coverage.gypi
diff --git a/build/ios/coverage.gypi b/build/ios/coverage.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..0b9613139401e53d693b90d2a34a0e2fdd023da7
--- /dev/null
+++ b/build/ios/coverage.gypi
@@ -0,0 +1,40 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'variables': {
+    'chromium_code': 1,
+    'enable_coverage%': 0,
+  },
+  'conditions': [
+    ['OS=="ios" and enable_coverage', {
+        'target_defaults': {
+          'variables': {
+             'developer_dir': '<!(xcode-select -print-path)',
+          },
+          'defines': [
+            'ENABLE_TEST_CODE_COVERAGE=1'
+          ],
+          'link_settings': {
+            'libraries': [
+              # There is no short name for clang coverage library like it was
+              # for GCC. Xcode automatically links the binary with
+              # libclang_rt.profile_ios if GCC_INSTRUMENT_PROGRAM_FLOW_ARCS and
+              # GCC_GENERATE_TEST_COVERAGE_FILES flags are set to YES. Since
+              # Xcode is not used for compilation binaries must be manually
+              # linked with libclang_rt.profile_ios.

[Nico, 2015/01/20 19:04:25]

This looks all kinds of wrong.

1.) If gyp's xcode emulation in the ninja generator doesn't work like xcode, we
should fix that
2.) this flag isn't added by xcode, it's added by clang – if -fprofile-arcs is
passed to the linker. So rather than doing this hack, you should probably just
add -fprofile-arcs to OTHER_LDFLAGS.
3.) Does anyone look at this data? People add coverage information to chrome
every other year, then nobody looks at the data, the coverage build file stuff
ends up being a pain, someone else removes it, and it's a bunch of busywork each
time. Is this actually in use?

[Eugene But (OOO till 7-30), 2015/01/21 00:18:40]

Filed a bug: crbug.com/450379
Done. Requires clang_xcode to be 1.

+              '<(developer_dir)/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/6.0/lib/darwin/libclang_rt.profile_ios.a',
+            ],
+          },
+          'xcode_settings': {
+            'OTHER_CFLAGS': [
+              '-fprofile-arcs',
+              '-ftest-coverage',
+            ],
+          },
+        },
+    }],
+  ],
+}
+