Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 853143002: Add Romanian standard keyboard (Closed)

Created:
5 years, 11 months ago by Shu Chen
Modified:
5 years, 11 months ago
Reviewers:
jwd, Seigo Nonaka
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Romanian standard keyboard. BUG=243440 TEST=Verified on clapper. Committed: https://crrev.com/678686d7440e28b1c687719787c028f0bb1b2535 Cr-Commit-Position: refs/heads/master@{#312329}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chromeos/ime/input_methods.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -3 lines 3 comments Download

Messages

Total messages: 13 (3 generated)
Shu Chen
Nona, can you please review this cl? Thanks
5 years, 11 months ago (2015-01-16 05:17:40 UTC) #2
Shu Chen
+jwd@ for histograms.xml changes.
5 years, 11 months ago (2015-01-16 06:34:10 UTC) #4
Shu Chen
Pinging... jwd@, can you please take a look? Your approval is required for the changes ...
5 years, 11 months ago (2015-01-20 01:56:26 UTC) #5
Seigo Nonaka
https://codereview.chromium.org/853143002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/853143002/diff/20001/tools/metrics/histograms/histograms.xml#newcode49109 tools/metrics/histograms/histograms.xml:49109: + <int value="111401" label="xkb:ro:std:rum">Romanian Standard keyboard</int> Is it fine ...
5 years, 11 months ago (2015-01-20 02:03:38 UTC) #6
Shu Chen
https://codereview.chromium.org/853143002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/853143002/diff/20001/tools/metrics/histograms/histograms.xml#newcode49109 tools/metrics/histograms/histograms.xml:49109: + <int value="111401" label="xkb:ro:std:rum">Romanian Standard keyboard</int> On 2015/01/20 02:03:38, ...
5 years, 11 months ago (2015-01-20 02:18:39 UTC) #7
Seigo Nonaka
lgtm https://codereview.chromium.org/853143002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/853143002/diff/20001/tools/metrics/histograms/histograms.xml#newcode49109 tools/metrics/histograms/histograms.xml:49109: + <int value="111401" label="xkb:ro:std:rum">Romanian Standard keyboard</int> On 2015/01/20 ...
5 years, 11 months ago (2015-01-20 06:27:21 UTC) #8
jwd
lgtm
5 years, 11 months ago (2015-01-20 18:18:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853143002/20001
5 years, 11 months ago (2015-01-21 01:14:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-21 13:58:29 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 13:59:45 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/678686d7440e28b1c687719787c028f0bb1b2535
Cr-Commit-Position: refs/heads/master@{#312329}

Powered by Google App Engine
This is Rietveld 408576698