Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 853133002: Remove glib from the mojo build. (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove glib from the mojo build. Now that pango and cairo have been removed from the mojo build, we can further remove glib if we set some options in the gn flags. BUG=443439 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c9ff02375165d4434fe7c00fd43218c46c09749f

Patch Set 1 #

Patch Set 2 : State after the previous roll. #

Patch Set 3 : Now updated after two rolls. #

Total comments: 2

Patch Set 4 : Remove x11_event_source_glib.cc #

Patch Set 5 : Also use_glib=false on Chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -114 lines) Patch
M mojo/tools/mojob.py View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/BUILD.gn View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M ui/events/platform/BUILD.gn View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
D ui/events/platform/x11/x11_event_source_glib.cc View 1 2 3 1 chunk +0 lines, -101 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Elliot Glaysher
This patch probably can't land as is. Given https://github.com/domokit/mojo/wiki/Directory-guide, is the correct thing to do ...
5 years, 11 months ago (2015-01-15 23:29:06 UTC) #2
jamesr
On 2015/01/15 23:29:06, Elliot Glaysher wrote: > This patch probably can't land as is. > ...
5 years, 11 months ago (2015-01-15 23:43:56 UTC) #3
Elliot Glaysher
This is ready for review now that I rolled the skia changes into mojo.
5 years, 11 months ago (2015-01-22 22:56:26 UTC) #4
jamesr
https://codereview.chromium.org/853133002/diff/40001/ui/base/BUILD.gn File ui/base/BUILD.gn (right): https://codereview.chromium.org/853133002/diff/40001/ui/base/BUILD.gn#newcode50 ui/base/BUILD.gn:50: if (use_glib) { we never set this, right? can ...
5 years, 11 months ago (2015-01-22 23:12:05 UTC) #5
Elliot Glaysher
Done. (And removed the glib source file.)
5 years, 11 months ago (2015-01-22 23:17:37 UTC) #6
jamesr
sweet! lgtm
5 years, 11 months ago (2015-01-22 23:56:42 UTC) #7
Elliot Glaysher
5 years, 11 months ago (2015-01-22 23:59:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
c9ff02375165d4434fe7c00fd43218c46c09749f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698