Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 853103004: Import Mojo Changes (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang, Nico, scottmg
CC:
chromium-reviews, erikwright+watch_chromium.org, jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make |use_glib| configurable. This is needed for mojo. We're trying to remove glib and dbus from our build, and need to be able to configure this option. This will be rolled back into the mojo repository. This was split from the mojo patch: https://codereview.chromium.org/853133002/ BUG=443439 Committed: https://crrev.com/9252aff86f89f9ae0293a81b46097b1b51a6b553 Cr-Commit-Position: refs/heads/master@{#312261}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M base/BUILD.gn View 2 chunks +7 lines, -2 lines 0 comments Download
M build/config/ui.gni View 2 chunks +4 lines, -3 lines 3 comments Download

Messages

Total messages: 14 (4 generated)
Elliot Glaysher
5 years, 11 months ago (2015-01-16 01:05:17 UTC) #2
Elliot Glaysher
Nico appears to be unavailable. scottmg: build/ thestig: base/
5 years, 11 months ago (2015-01-20 18:04:34 UTC) #4
Elliot Glaysher
Nico appears to be unavailable. scottmg: build/ thestig: base/
5 years, 11 months ago (2015-01-20 18:04:42 UTC) #6
scottmg
The cl description got truncated. https://codereview.chromium.org/853103004/diff/1/build/config/ui.gni File build/config/ui.gni (left): https://codereview.chromium.org/853103004/diff/1/build/config/ui.gni#oldcode57 build/config/ui.gni:57: use_glib = is_linux && ...
5 years, 11 months ago (2015-01-20 18:09:52 UTC) #7
Elliot Glaysher
https://codereview.chromium.org/853103004/diff/1/build/config/ui.gni File build/config/ui.gni (left): https://codereview.chromium.org/853103004/diff/1/build/config/ui.gni#oldcode57 build/config/ui.gni:57: use_glib = is_linux && !use_ozone On 2015/01/20 18:09:51, scottmg ...
5 years, 11 months ago (2015-01-20 18:14:14 UTC) #8
scottmg
lgtm https://codereview.chromium.org/853103004/diff/1/build/config/ui.gni File build/config/ui.gni (left): https://codereview.chromium.org/853103004/diff/1/build/config/ui.gni#oldcode57 build/config/ui.gni:57: use_glib = is_linux && !use_ozone On 2015/01/20 18:14:13, ...
5 years, 11 months ago (2015-01-20 18:16:36 UTC) #9
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-20 20:12:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853103004/1
5 years, 11 months ago (2015-01-20 20:18:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 20:25:54 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 20:27:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9252aff86f89f9ae0293a81b46097b1b51a6b553
Cr-Commit-Position: refs/heads/master@{#312261}

Powered by Google App Engine
This is Rietveld 408576698