Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 853073002: Update {virtual,override,final} to follow C++11 style in ui. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, penghuang+watch_chromium.org, stevenjb+watch_chromium.org, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in ui. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=avi@chromium.org Committed: https://crrev.com/eb25a619587ab419e2a4f5d3486b8bb2d8e8a5ff Cr-Commit-Position: refs/heads/master@{#311759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -270 lines) Patch
M ui/base/ime/chromeos/fake_ime_keyboard.h View 1 chunk +11 lines, -12 lines 0 comments Download
M ui/base/ime/chromeos/fake_input_method_delegate.h View 1 chunk +5 lines, -6 lines 0 comments Download
M ui/base/ime/chromeos/ime_bridge.cc View 1 chunk +10 lines, -13 lines 0 comments Download
M ui/base/ime/chromeos/ime_keyboard_x11.h View 1 chunk +10 lines, -11 lines 0 comments Download
M ui/base/ime/chromeos/mock_component_extension_ime_manager_delegate.h View 1 chunk +10 lines, -10 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_candidate_window_handler.h View 1 chunk +8 lines, -8 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_engine_handler.h View 1 chunk +15 lines, -14 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_input_context_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/base/ime/input_method_chromeos.h View 3 chunks +22 lines, -22 lines 0 comments Download
M ui/base/ime/input_method_chromeos_unittest.cc View 5 chunks +39 lines, -56 lines 0 comments Download
M ui/chromeos/network/network_icon.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/chromeos/network/network_icon_animation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/chromeos/network/network_list.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/chromeos/network/network_state_notifier.h View 1 chunk +3 lines, -5 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.h View 2 chunks +6 lines, -5 lines 0 comments Download
M ui/chromeos/touch_exploration_controller_unittest.cc View 4 chunks +11 lines, -20 lines 0 comments Download
M ui/chromeos/user_activity_power_manager_notifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/display/chromeos/display_configurator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M ui/display/chromeos/test/test_display_snapshot.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/display/chromeos/update_display_configuration_task_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/display/chromeos/x11/display_mode_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/chromeos/x11/display_snapshot_x11.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.h View 1 chunk +24 lines, -29 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M ui/display/chromeos/x11/native_display_event_dispatcher_x11.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/display/chromeos/x11/native_display_event_dispatcher_x11_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M ui/views_content_client/views_content_client_main_parts_chromeos.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
5 years, 11 months ago (2015-01-15 21:29:11 UTC) #1
Avi (use Gerrit)
lgtm stampity stamp
5 years, 11 months ago (2015-01-15 21:37:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853073002/1
5 years, 11 months ago (2015-01-15 21:41:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 23:11:51 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 23:12:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb25a619587ab419e2a4f5d3486b8bb2d8e8a5ff
Cr-Commit-Position: refs/heads/master@{#311759}

Powered by Google App Engine
This is Rietveld 408576698