Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 853033002: More delete + gfx_unittests (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete more code, and hook up gfx_unittests. While deleting code, I saw that gfx_unittests wasn't hooked up. Added it to the build rules and the mojob.py list. BUG=443439 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ba75a33f79f5f67a0e8f307217e662ed5b86f50b

Patch Set 1 #

Patch Set 2 : Fix android trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -883 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/tools/data/unittests View 1 chunk +5 lines, -0 lines 0 comments Download
D ui/android/java/src/org/chromium/ui/base/TouchDevice.java View 1 chunk +0 lines, -51 lines 0 comments Download
M ui/base/BUILD.gn View 1 6 chunks +0 lines, -30 lines 0 comments Download
M ui/base/android/ui_base_jni_registrar.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/test/run_all_unittests.cc View 2 chunks +0 lines, -29 lines 0 comments Download
D ui/base/touch/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/base/touch/touch_device.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/base/touch/touch_device.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/base/touch/touch_device_android.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/base/touch/touch_device_win.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/base/touch/touch_device_x11.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/base/touch/touch_enabled.h View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/base/touch/touch_enabled.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/base/ui_base_paths.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/base/ui_base_paths.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D ui/base/ui_base_switches_util.h View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/base/ui_base_switches_util.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/base/ui_base_types.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/base/ui_base_types.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/base/x/x11_foreign_window_manager.h View 1 chunk +0 lines, -69 lines 0 comments Download
D ui/base/x/x11_foreign_window_manager.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D ui/base/x/x11_menu_list.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/base/x/x11_menu_list.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M ui/base/x/x11_util.h View 1 chunk +0 lines, -21 lines 0 comments Download
M ui/base/x/x11_util.cc View 2 chunks +0 lines, -76 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/test/run_all_unittests.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Elliot Glaysher
5 years, 11 months ago (2015-01-15 19:17:29 UTC) #2
sky
LGTM
5 years, 11 months ago (2015-01-15 19:28:50 UTC) #3
Elliot Glaysher
5 years, 11 months ago (2015-01-15 20:16:22 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ba75a33f79f5f67a0e8f307217e662ed5b86f50b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698