Error recovery broke host checked mode, fix it.

dart/pkg/compiler/lib/src/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaFunctionCompiler implements FunctionCompiler {
   SsaCodeGeneratorTask generator;
   SsaBuilderTask builder;
   SsaOptimizerTask optimizer;
@@ skipping 2009 matching lines @@
     // Call the JavaScript constructor with the fields as argument.
     List<HInstruction> constructorArguments = <HInstruction>[];
     List<Element> fields = <Element>[];
 
     classElement.forEachInstanceField(
         (ClassElement enclosingClass, VariableElement member) {
           HInstruction value = fieldValues[member];
           if (value == null) {
             // Uninitialized native fields are pre-initialized by the native
             // implementation.
-            assert(isNativeUpgradeFactory);
+            assert(invariant(
+                member, isNativeUpgradeFactory || compiler.compilationFailed));
           } else {
             fields.add(member);
             DartType type = localsHandler.substInContext(member.type);
             constructorArguments.add(potentiallyCheckOrTrustType(value, type));
           }
         },
         includeSuperAndInjectedMembers: true);
 
     InterfaceType type = classElement.thisType;
     TypeMask ssaType =
@@ skipping 1225 matching lines @@
       if (element.isSetter) {
         pushInvokeStatic(location, element, <HInstruction>[value]);
         pop();
       } else {
         VariableElement field = element;
         value = potentiallyCheckOrTrustType(value, field.type);
         addWithPosition(new HStaticStore(element, value), location);
       }
       stack.add(value);
     } else if (Elements.isErroneousElement(element)) {
-      List<HInstruction> arguments =
-          send == null ? const <HInstruction>[] : <HInstruction>[value];
-      // An erroneous element indicates an unresolved static setter.
-      generateThrowNoSuchMethod(location,
-                                noSuchMethodTargetSymbolString(element, 'set'),
-                                argumentValues: arguments);
+      if (element is ErroneousElement) {
+        List<HInstruction> arguments =
+            send == null ? const <HInstruction>[] : <HInstruction>[value];
+        // An erroneous element indicates an unresolved static setter.
+        generateThrowNoSuchMethod(
+            location, noSuchMethodTargetSymbolString(element, 'set'),
+            argumentValues: arguments);
+      } else {
+        // TODO(ahe): Do something like [generateWrongArgumentCountError].
+        stack.add(graph.addConstantNull(compiler));
+      }
     } else {
       stack.add(value);
       LocalElement local = element;
       // If the value does not already have a name, give it here.
       if (value.sourceElement == null) {
         value.sourceElement = local;
       }
       HInstruction checkedOrTrusted =
           potentiallyCheckOrTrustType(value, local.type);
       if (!identical(checkedOrTrusted, value)) {
@@ skipping 1190 matching lines @@
     Selector selector = elements.getSelector(node);
     Element element = elements[node];
     if (elements.isAssert(node)) {
       element = backend.assertMethod;
     }
     if (element.isForeign(backend) && element.isFunction) {
       visitForeignSend(node);
       return;
     }
     if (element.isErroneous) {
-      // An erroneous element indicates that the funciton could not be resolved
-      // (a warning has been issued).
-      generateThrowNoSuchMethod(node,
-                                noSuchMethodTargetSymbolString(element),
-                                argumentNodes: node.arguments);
+      if (element is ErroneousElement) {
+        // An erroneous element indicates that the funciton could not be
+        // resolved (a warning has been issued).
+        generateThrowNoSuchMethod(node,
+                                  noSuchMethodTargetSymbolString(element),
+                                  argumentNodes: node.arguments);
+      } else {
+        // TODO(ahe): Do something like [generateWrongArgumentCountError].
+        stack.add(graph.addConstantNull(compiler));
+      }
       return;
     }
     invariant(element, !element.isGenerativeConstructor);
     generateIsDeferredLoadedCheckIfNeeded(node);
     if (element.isFunction) {
       // TODO(5347): Try to avoid the need for calling [implementation] before
       // calling [makeStaticArgumentList].
       if (!selector.applies(element.implementation, compiler.world)) {
         generateWrongArgumentCountError(node, element, node.arguments);
         return;
@@ skipping 2152 matching lines @@
     if (unaliased is TypedefType) throw 'unable to unalias $type';
     unaliased.accept(this, builder);
   }
 
   void visitDynamicType(DynamicType type, SsaBuilder builder) {
     JavaScriptBackend backend = builder.compiler.backend;
     ClassElement cls = backend.findHelper('DynamicRuntimeType');
     builder.push(new HDynamicType(type, new TypeMask.exact(cls, classWorld)));
   }
 }